Refactor #34234
Do not warn on HTTP connection from Smart proxy
Pull request:
Fixed in Releases:
Found in Releases:
Description
When ssl is enabled, pure HTTP connections on smart-proxy enabled endpoints are allowed, just to throw an warning about such behaviour.
To support this further in Rails 6.1 would be big effort (because of #30122) with very little benefit.
Related issues
Associated revisions
History
#1
Updated by Ondřej Ezr 4 months ago
- Related to Refactor #30122: Remove usage of force_ssl in controller added
#2
Updated by The Foreman Bot 4 months ago
- Assignee set to Ondřej Ezr
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/9020 added
#3
Updated by The Foreman Bot 4 months ago
- Fixed in Releases 3.2.0 added
#4
Updated by Ondřej Ezr 4 months ago
- Status changed from Ready For Testing to Closed
Applied in changeset foreman|a96fc62a5eb3c320983a44e068d799e465f65b0e.
Fixes #34234 - do not allow HTTP on SmartProxy Auth
SmartProxyAuth enabled on its endpoints HTTP to log a message, that ssl is required.
This in not necessary and it is hard to keep for the future as Rails 6.1 will make that harder.
There is not too much benefit from this, so it's better to drop it.