Feature #34280: Add `ip_include?` method to IPAM::Base that uses `IPAddr#include?` method - Foreman

Actions

Copy link

Feature #34280

closed

Add `ip_include?` method to IPAM::Base that uses `IPAddr#include?` method

Added by Jan Matusz over 2 years ago. Updated about 2 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Jan Matusz

Category:

Network

Target version:

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/9036

Fixed in Releases:

3.2.0

Found in Releases:

Red Hat JIRA:

Description

Related to: https://github.com/theforeman/foreman_discovery/pull/545

We need to be able to validate whether user sourced IP set in the form is included in the available subnet.
Initially we just ran `.include?` on a Range object generated through `subnet_range` method, however, this is extremely inefficient when used on huge subnets (specifically in this case, an IPv6 range inclusion check timed out).

This brought `IPAddr#include` to the spotlight.