Project

General

Profile

Bug #34300

Host form redirect relies on the primary interface being the first interface

Added by Ondřej Ezr 10 months ago. Updated 10 months ago.

Status:
Closed
Priority:
High
Assignee:
Category:
Host creation
Target version:
Difficulty:
easy
Triaged:
Yes
Bugzilla link:
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

We have used wrong fetching mechanism for a host's fqdn in https://github.com/theforeman/foreman/blob/0d80e696c089ed7cb4eb3e2951302cd9f67ecd37/app/assets/javascripts/host_edit.js#L162

This relies on the fact, that primary interface defining domain is usually first, but on cases when this is not true, this check fails.


Related issues

Related to Foreman - Feature #33484: Add setting for redirecting to the new host details page Closed
Related to Foreman - Bug #34371: Host form redirect does not work for unmanaged hostClosed
Related to Foreman - Bug #34572: The Submit button on a host form redirects to an invalid pageClosed

Associated revisions

Revision 08a74cb7 (diff)
Added by Ondřej Ezr 10 months ago

Fixes #34300 - correctly construct the fqdn for redirect

In host form we've used a hack in 28765788dc to redirect to the new Host details page.
It relied on the primary interface being the first interface in the table.

This fixes it to always incur the correct fqdn.

History

#1 Updated by Ondřej Ezr 10 months ago

  • Related to Feature #33484: Add setting for redirecting to the new host details page added

#2 Updated by Ondřej Ezr 10 months ago

  • Priority changed from Normal to High

#3 Updated by The Foreman Bot 10 months ago

  • Assignee set to Ondřej Ezr
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/9047 added

#4 Updated by The Foreman Bot 10 months ago

  • Fixed in Releases 3.2.0 added

#5 Updated by Ewoud Kohl van Wijngaarden 10 months ago

  • Triaged changed from No to Yes
  • Fixed in Releases 3.1.1 added

#6 Updated by Ondřej Ezr 10 months ago

  • Status changed from Ready For Testing to Closed

#7 Updated by Ondřej Ezr 10 months ago

  • Related to Bug #34371: Host form redirect does not work for unmanaged host added

#8 Updated by Ondřej Ezr 9 months ago

  • Related to Bug #34572: The Submit button on a host form redirects to an invalid page added

Also available in: Atom PDF