Project

General

Profile

Bug #34328

Tracker #29939: Improve setting definition DSL and move setting registry to memory

GraphQL is using Setting model directly

Added by Ondřej Ezr about 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Ondřej Ezr
Category:
Settings
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/9066
Fixed in Releases:
3.3.0
Found in Releases:
Red Hat JIRA:

Description

GraphQL is using Setting model and database directly, but it needs to go through the registry to continue to work as expected (getting the correct values on read and write correctly)

Subtasks

Refactor #34335: Make GraphQL read settings from RegistryRejectedOndřej Ezr

Associated revisions

Revision 09414bf0 (diff)
Added by Ondřej Ezr about 1 year ago

Fixes #34328 - GraphQL use directly SettingRegistry

GraphQL was reading the settings from DB, but now we have the registry, it needs to read it from there instead.

Mutation needs to set the value through the SettingRegistry as well.

History

#1 Updated by Ondřej Ezr about 1 year ago

  • Parent task set to #29939

#2 Updated by The Foreman Bot about 1 year ago

  • Assignee set to Ondřej Ezr
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/9066 added

#3 Updated by The Foreman Bot about 1 year ago

  • Fixed in Releases 3.3.0 added

#4 Updated by Ondřej Ezr about 1 year ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF