Bug #34329
closedAllow specific permissions to be excluded from being added to default roles
Description
If I understood the permission related helpers in app/registries/plugin.rb we have a couple options:
1) add_permissions_to_default_roles - Here I'd need to list ALL the permissions except the one I don't want included. Also one needs to separate the different permissions for viewer/manager by hand. Apart from it being ugly, I couldn't manage to get it working at all. All attempts failed with
foreman/app/models/role.rb:336:in `permission_records': ERF73-0602 [Foreman::PermissionMissingException]: »some permissions were not found: []« (Foreman::PermissionMissingException)
2) add_resource_permissions_to_default_roles - Here I'd need to list all the resources and according to the comment above the method I should be able to pass an array of permissions to be excluded. Sounds good, doesn't work. Interestingly enough, all attempts failed with the same error as option 1.
Here I propose to add a keyword argument "except" to add_all_permissions_to_default_roles, which would prevent listed permissions from being added to the default roles. It is more inline with the idea of "add all permissions except for the selected few" rather than "to exclude this permission, I need to explicitly state all that should be included"
Updated by Adam Ruzicka about 3 years ago
- Related to Bug #34324: Manager role does contain the execute_jobs_on_infrastructure_hosts permission added
Updated by The Foreman Bot about 3 years ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/9064 added
Updated by Adam Ruzicka almost 3 years ago
- Status changed from Ready For Testing to Closed
Applied in changeset foreman|ef2ff06831ae7efcdab247b13c9ff642c6d56688.
Updated by The Foreman Bot almost 3 years ago
- Pull request https://github.com/theforeman/foreman/pull/9072 added