Refactor #34339
Sanitize FQDN in tests
Description
We are using two fqdns in tests, one comming from setting.yaml.test, that is not used, because it is overriden by another one from `fixtures/settings.yml`
We should get them in sync and then remove the override from fixtures and always use what's defined in settings.yaml.test
Related issues
Associated revisions
History
#1
Updated by Ondřej Ezr about 1 year ago
Updated by - Related to Bug #34323: The Setting defaults are never updated added
#2
Updated by The Foreman Bot about 1 year ago
Updated by - Assignee set to Ondřej Ezr
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/9068 added
#3
Updated by The Foreman Bot about 1 year ago
- Fixed in Releases 3.3.0 added
#4
Updated by Ondřej Ezr about 1 year ago
- Status changed from Ready For Testing to Closed
Applied in changeset foreman|0ed80f4540d51d28780aa6242f2763a9df130bc0.
#5
Updated by Amit Upadhye 10 months ago
Updated by - Subject changed from Sanitize fqdn in tests to Sanitize FQDN in tests
Fixes #34339 - sanitize fqdn in tests
Tests were almost not using the fqdn defined in settings.yaml.test
That is quite confusing at first sight and we should not override this value by fixtures, only if overriden in the same test file.