Project

General

Profile

Refactor #34339

Sanitize FQDN in tests

Added by Ondřej Ezr 5 months ago. Updated 19 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Tests
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

We are using two fqdns in tests, one comming from setting.yaml.test, that is not used, because it is overriden by another one from `fixtures/settings.yml`
We should get them in sync and then remove the override from fixtures and always use what's defined in settings.yaml.test


Related issues

Related to Foreman - Bug #34323: The Setting defaults are never updated Closed

Associated revisions

Revision 0ed80f45 (diff)
Added by Ondřej Ezr 4 months ago

Fixes #34339 - sanitize fqdn in tests

Tests were almost not using the fqdn defined in settings.yaml.test
That is quite confusing at first sight and we should not override this value by fixtures, only if overriden in the same test file.

History

#1 Updated by Ondřej Ezr 5 months ago

  • Related to Bug #34323: The Setting defaults are never updated added

#2 Updated by The Foreman Bot 5 months ago

  • Assignee set to Ondřej Ezr
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/9068 added

#3 Updated by The Foreman Bot 4 months ago

  • Fixed in Releases 3.3.0 added

#4 Updated by Ondřej Ezr 4 months ago

  • Status changed from Ready For Testing to Closed

#5 Updated by Amit Upadhye 19 days ago

  • Subject changed from Sanitize fqdn in tests to Sanitize FQDN in tests

Also available in: Atom PDF