Project

General

Profile

Bug #34375

Facets do not allow emptying their relations through mass assignment

Added by Ondřej Ezr 4 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Plugin integration
Target version:
Difficulty:
Triaged:
No
Bugzilla link:

Description

Facets do not allow passing empty values not to create empty asset in DB, but I believe it is not worth this not working eighter:

host.attributes = { facet_attributes: { facet_association_ids: [] }}

Causes: https://github.com/theforeman/foreman_puppet/issues/253

Associated revisions

Revision 92ac0e94 (diff)
Added by Ondřej Ezr 3 months ago

Fixes #34375 - allow passing empty attributes for facets (#9083)

Facets were rejecting empty attributes to not create empty facet.
Originally this was to fix an issue in 5d64eef2cba8e56ad39510c3bd1d724bd52762eb
Tho we want to pass empty attributes to facets that already exists.
We just don't want to create empty ones.

History

#1 Updated by Ondřej Ezr 4 months ago

  • Target version set to 3.1.2

#2 Updated by The Foreman Bot 4 months ago

  • Assignee set to Ondřej Ezr
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/9083 added

#3 Updated by Ondřej Ezr 4 months ago

  • Bugzilla link set to 2046573

#4 Updated by The Foreman Bot 3 months ago

  • Fixed in Releases 3.2.0 added

#5 Updated by Ondřej Ezr 3 months ago

  • Status changed from Ready For Testing to Closed

#6 Updated by Ondřej Ezr 3 months ago

  • Fixed in Releases 3.3.0 added
  • Fixed in Releases deleted (3.2.0)

#7 Updated by The Foreman Bot 3 months ago

  • Pull request https://github.com/theforeman/foreman/pull/9111 added

#8 Updated by The Foreman Bot 3 months ago

  • Fixed in Releases 3.1.3 added

#9 Updated by Amit Upadhye 3 months ago

  • Fixed in Releases 3.1.2 added
  • Fixed in Releases deleted (3.1.3)

#10 Updated by Amit Upadhye 3 months ago

  • Fixed in Releases 3.2.0 added

Also available in: Atom PDF