Project

General

Profile

Bug #34396

Job report template enhancements

Added by Marek Hulán 5 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Associated revisions

Revision edbd77ed (diff)
Added by Marek Hulán about 2 months ago

Fixes #34396 - job report tweaks

This change adds few enhancements to the existing Job report. The report
is used with REX plugin, which has a button "Create Report" in job
detail page. Clicking that button takes user to the render report form
and fills in the job id input.

The enhancements:
1) rename the template to Job - Invocation Report to be more consistent
with other report templates
2) Add missing `-` to closing `%>` erb tags to avoid empty lines in the
output
3) don't fail on ended_at being nil, meaning on jobs that are still
running, instead use empty value in such case
4) the format_time macro keeps month and day as two digits

The follow up is necessary in the REX plugin so the setting default
value reflects the new name.

History

#1 Updated by The Foreman Bot 5 months ago

  • Assignee set to Marek Hulán
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/9093 added

#2 Updated by The Foreman Bot about 2 months ago

  • Fixed in Releases 3.4.0 added

#3 Updated by Marek Hulán about 2 months ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF