Project

General

Profile

Actions

Bug #34456

closed

ReclaimSpace does not acquire repo lock so it can be run concurrently with the repo sync

Added by Samir Jha over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
High
Assignee:
Category:
Repositories
Target version:
Difficulty:
Triaged:
Yes
Fixed in Releases:
Found in Releases:

Description

Description of problem:
The described observation is not a bug per se and I dont even know if it can lead to a problem. But ReclaimSpace task does not acquire any lock, and it can be concurrently executed to the repo sync or content validation (successfully tried both).

Doing concurrently two different (in some way opposite) activities on a repo sounds as a potential problem, hence raising it this way. If that concurrent activity can trigger a problem, please add repo lock to ReclaimSpace task. If not, close this BZ as NOTABUG.

Version-Release number of selected component (if applicable):
Sat 7.0 snap 9

How reproducible:
100%

Steps to Reproduce:
1. Sync a (bigger) repo with On Demand download policy
2. Open the repo in WebUI in two tabs.
3. Quickly one after another, initiate sync and reclaim space tasks from the two tabs.
4. Check the task details / ReclaimSpace task locks.

Actual results:
4. It is possible to have the tasks running concurrently. ReclaimSpace does not acquire any lock.

Expected results:
Add the repo lock to ReclaimSpace in case it is needed.

Additional info:

Actions #1

Updated by The Foreman Bot over 2 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Samir Jha
  • Pull request https://github.com/Katello/katello/pull/9952 added
Actions #2

Updated by Jonathon Turel over 2 years ago

  • Subject changed from ReclaimSpace does not acquire repo lock so it can be run concurrently with the repo sync to ReclaimSpace does not acquire repo lock so it can be run concurrently with the repo sync
  • Triaged changed from No to Yes
Actions #3

Updated by The Foreman Bot over 2 years ago

  • Fixed in Releases Katello 4.5.0 added
Actions #4

Updated by Samir Jha over 2 years ago

  • Status changed from Ready For Testing to Closed
Actions #5

Updated by The Foreman Bot over 2 years ago

  • Pull request https://github.com/Katello/katello/pull/9899 added
Actions #6

Updated by Ian Ballou over 2 years ago

  • Pull request deleted (https://github.com/Katello/katello/pull/9899)
Actions

Also available in: Atom PDF