Project

General

Profile

Actions

Bug #34525

closed

Ensure that the insights snippet is being called by honoring the value of host_registration_insights parameter

Added by Sayan Das over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Templates
Target version:
-

Description

Description of problem:

The insights registration steps happen during host build even if the host_registration_insights parameter is set to false in Satellite 7.0

The problem is that we call the snippet "insights" directly in "kickstart default" template without validating the conditional.

Steps to Reproduce:

1. Build a Satellite 7 beta and configure it for PXE provisioning

2. Set the value of "host_registration_insights" boolean to false in global parameters.

3. Create and submit the host for build.

4. Once the host is built either render the Provisioning template against the host or else check the /root/install.post.log file on the host.

Actual results:

We will be able to see that even after the host_registration_insights parameter is set to false, as a part of build process, the insights-client package was installed and the registration was attempted.

Expected results:

The build process should honor the value of host_registration_insights boolean and based on that, it should execute the insights-related actions in the post-provisioning steps.

Additional info:

In kickstart_default template and kickstart_ovirt template, we directly call the snippet for insights in this way:

<%= snippet 'insights' -%>

but it should be called in this way:

<% if host_param_true?('host_registration_insights') ->
<
= snippet 'insights' ->
<
end -%>

Actions #1

Updated by The Foreman Bot over 2 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/9121 added
Actions #2

Updated by Sayan Das over 2 years ago

  • Assignee set to Sayan Das
Actions #3

Updated by The Foreman Bot over 2 years ago

  • Fixed in Releases 3.3.0 added
Actions #4

Updated by Sayan Das over 2 years ago

  • Status changed from Ready For Testing to Closed
Actions #5

Updated by The Foreman Bot over 2 years ago

  • Pull request https://github.com/theforeman/foreman/pull/9143 added
Actions #6

Updated by The Foreman Bot over 2 years ago

  • Pull request https://github.com/theforeman/foreman/pull/9144 added
Actions #7

Updated by The Foreman Bot over 2 years ago

  • Fixed in Releases 3.2.0 added
Actions #8

Updated by The Foreman Bot over 2 years ago

  • Fixed in Releases 3.1.3 added
Actions

Also available in: Atom PDF