Project

General

Profile

Feature #34526

Switch Rails version to 6.1

Added by Leos Stejskal about 1 year ago. Updated 8 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Rails
Target version:

Related issues

Related to Foreman - Tracker #28570: Rails 6.1 TrackerNew

Related to foreman-tasks - Bug #34956: Fix breakages caused by rails 6.1 upgradeClosed

Associated revisions

Revision 8c4d848f (diff)
Added by Leos Stejskal 12 months ago

Fixes #34526 - rescue_from JSON params parse errors

Use rescue_from block instead of the CatchJsonParseErrors middleware
See https://github.com/rails/rails/pull/34341

Revision 1cf4147a (diff)
Added by Leos Stejskal 10 months ago

Fixes #34526 - Switch Rails version to 6.1

Changes overview:
- Set default Rails version to 6.1
- Required dynfow >= 1.6.5
- Cleanup deprecation warnings in config/as_deprecation_whitelist.yaml
- ActiveSupport::ParameterFilter instead of ActionDispatch::Http::ParameterFilter
- model.errors.attribute_names instead of model.errors.keys
- Fixed issue with iterating over the model.errors
- use .add for adding error messages instead of <<
- 'where.not' use NAND instead of NOR [0]

[0] https://github.com/rails/rails/pull/36029

Revision 5b2789c1 (diff)
Added by Evgeni Golov 10 months ago

Refs #34526 - Update Rails to 6.1.6

Revision 26417655 (diff)
Added by Ewoud Kohl van Wijngaarden 8 months ago

Refs #34526 - Drop Rails 6.0 support code

When Foreman switched to Rails 6.1, Rails 6.0 compatibility was dropped.
This makes it fail hard when it is attempted to be used. it also removes
a stray backslash.

Fixes: 1cf4147a06420842d3818f4edb6e22892f40a939
Fixes: f95e36928306637843fdfb39ed5ffe1d5f5af782

History

#1 Updated by Leos Stejskal about 1 year ago

#2 Updated by The Foreman Bot about 1 year ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/9117 added

#3 Updated by The Foreman Bot about 1 year ago

  • Pull request https://github.com/theforeman/foreman/pull/9157 added

#4 Updated by The Foreman Bot 12 months ago

  • Fixed in Releases 3.3.0 added

#5 Updated by Leos Stejskal 12 months ago

  • Status changed from Ready For Testing to Closed

#6 Updated by The Foreman Bot 10 months ago

  • Fixed in Releases 3.4.0 added

#7 Updated by The Foreman Bot 10 months ago

  • Pull request https://github.com/theforeman/foreman/pull/9231 added

#8 Updated by Adam Ruzicka 10 months ago

  • Related to Bug #34956: Fix breakages caused by rails 6.1 upgrade added

#9 Updated by Ewoud Kohl van Wijngaarden 8 months ago

  • Triaged changed from No to Yes
  • Target version set to 3.4.0
  • Fixed in Releases deleted (3.3.0)

This was not included in 3.3. 596e12870ba522090f055cbde538dfaed7ef38fb should not have use Fixes but Refs.

#10 Updated by The Foreman Bot 8 months ago

  • Pull request https://github.com/theforeman/foreman/pull/9307 added

Also available in: Atom PDF