Feature #34526: Switch Rails version to 6.1 - Foreman

Feature #34526

Switch Rails version to 6.1

Added by Leos Stejskal about 1 year ago. Updated 8 months ago.

Status:

Closed

Priority:

Normal

Assignee:

Leos Stejskal

Category:

Rails

Target version:

3.4.0

Difficulty:

Triaged:

Yes

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/9117, https://github.com/theforeman/foreman/pull/9307, https://github.com/theforeman/foreman/pull/9231, https://github.com/theforeman/foreman/pull/9157

Fixed in Releases:

3.4.0

Found in Releases:

Red Hat JIRA:

Related issues

Associated revisions

Revision 8c4d848f (diff)
Added by Leos Stejskal 12 months ago

Fixes #34526 - rescue_from JSON params parse errors

Use rescue_from block instead of the CatchJsonParseErrors middleware
See https://github.com/rails/rails/pull/34341

Revision 1cf4147a (diff)
Added by Leos Stejskal 10 months ago

Fixes #34526 - Switch Rails version to 6.1

Changes overview:
- Set default Rails version to 6.1
- Required dynfow >= 1.6.5
- Cleanup deprecation warnings in config/as_deprecation_whitelist.yaml
- ActiveSupport::ParameterFilter instead of ActionDispatch::Http::ParameterFilter
- model.errors.attribute_names instead of model.errors.keys
- Fixed issue with iterating over the model.errors
- use .add for adding error messages instead of <<
- 'where.not' use NAND instead of NOR [0]

[0] https://github.com/rails/rails/pull/36029

Revision 5b2789c1 (diff)
Added by Evgeni Golov 10 months ago

Refs #34526 - Update Rails to 6.1.6

Revision 26417655 (diff)
Added by Ewoud Kohl van Wijngaarden 8 months ago

Refs #34526 - Drop Rails 6.0 support code

When Foreman switched to Rails 6.1, Rails 6.0 compatibility was dropped.
This makes it fail hard when it is attempted to be used. it also removes
a stray backslash.

Fixes: 1cf4147a06420842d3818f4edb6e22892f40a939
Fixes: f95e36928306637843fdfb39ed5ffe1d5f5af782