Project

General

Profile

Bug #34581

VCPUs_at_startup attribute not found, when deploying from Satellite 6

Added by Jonas Henriksen 5 months ago. Updated 5 months ago.

Status:
New
Priority:
Normal
Assignee:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
Fixed in Releases:
Found in Releases:

Description

When deploying a server from Satellite, we ran into an error that VCPUS_at_startup wasn't defined, and the deployment was rolled back. Looking through the source code, it appears that the commit that fixed issue 28003, changed the mixed case to lower case (snake case). In our own experiments we changed the casing back to mixed casing, and we could successfully deploy the server.

https://github.com/theforeman/foreman-xen/commit/26e9206804ae7db206167d61987caa85e1921c1c

We are running xcp-ng version: 8.2
Foreman-xen is 1.0.1

As example in xenadmin, the windows admin panel, the xenapi uses mixed case:

https://github.com/xenserver/xenadmin/blob/c506c5e47c110760d62a03f72775217943e3da54/XenModel/XenAPI/VM.cs

I can make a pull request, that changes the attributes, but I assume it was changed for a reason.

Best regards,
Jonas

History

#1 Updated by Jonas Henriksen 5 months ago

Satellite version 6.9.8
Foreman version 2.3.1

#2 Updated by Martin Juhl 5 months ago

Hi

I think that this bug has been solved incorrectly..

If you look at: https://github.com/xcp-ng/xen-api/blob/v21.4.0/ocaml/xapi/xapi_xenops.ml:1193 the variable is actually uses the uppercase variant..

Using the upstream 1.0.1 version fails for us, when trying to deploy, telling us that the uppercase variant of the variable can't be found...

I don't know how this has been working for @Nikola, but as far as I can tell, the variable has never been using the lower case variant..

Can we please reverse this commit?

Also available in: Atom PDF