Project

General

Profile

Refactor #34603

Tracker #29939: Improve setting definition DSL and move setting registry to memory

Deprecate other than DSL setting definitions

Added by Ondřej Ezr 4 months ago. Updated 24 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Settings
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

All setting should be defined through the setting DSL.


Related issues

Related to Katello - Refactor #34608: Use only public setting interface to update setting valuesClosed
Related to Boot disk - Refactor #34674: Use new DSL to define settingsClosed
Related to Discovery - Refactor #34677: Use new DSL to define settingsClosed
Follows Foreman - Refactor #33781: Deprecate the old setting definitions without "default_settings"Closed

Associated revisions

Revision fdd9d631 (diff)
Added by Ondřej Ezr 3 months ago

Fixes #34603 - deprecate non-DSL setting definitions

This allows conversion to Zeitwerk by moving the non-DSL setting to only
to_prepare phase. We no longer require the Setting classes manually.
If the plugins want to continue using the old way,
plugins need to require the Setting classes manually.

History

#1 Updated by The Foreman Bot 4 months ago

  • Assignee set to Ondřej Ezr
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/9150 added

#2 Updated by Ondřej Ezr 4 months ago

  • Related to Refactor #34608: Use only public setting interface to update setting values added

#3 Updated by Lukas Zapletal 3 months ago

#4 Updated by Lukas Zapletal 3 months ago

#5 Updated by The Foreman Bot 3 months ago

  • Fixed in Releases 3.3.0 added

#6 Updated by Ondřej Ezr 3 months ago

  • Status changed from Ready For Testing to Closed

#7 Updated by Ondřej Ezr 3 months ago

  • Follows Refactor #33781: Deprecate the old setting definitions without "default_settings" added

#8 Updated by Amit Upadhye 24 days ago

  • Subject changed from Deprecate other then DSL setting definitions to Deprecate other than DSL setting definitions

Also available in: Atom PDF