Bug #34659
closed
Katello bookmark icon should be consistent with Foreman's
Description
Right now Foreman uses the correct bookmark icon (white outline) and Katello uses the incorrect one (solid black). I think there were reasons for this, but I can't recall and anyway we should standardize it.
Files
| foreman_bookmarks.png | View foreman_bookmarks.png | 6.51 KB | bookmark icon from HW Models page | ||
| black_bookmark.png | View black_bookmark.png | 2.03 KB | bookmark icon from Repository sets |
Updated by
Updated by Andrew Dewar about 3 years ago
"I think there were reasons for this"
Indeed!
So, patternfly uses Font Awesome for their icon library. By default (and perhaps by design) only icons built with the "fas" or fa-solid style are supported, and thus why all patternfly components are using using "fas"/solid styled font-awesome icons. The iconography style/library for the "correct bookmark icon (white outline)" mentioned above would use the "far" or fa-regular font awesome library not supported out of the box from Patternfly.
To be consistent with Patternfly (not foreman), the choice was made when initially designing the bookmark functionality to use the iconography as supported by Patternfly. This was approved by design before applying.
Updated by The Foreman Bot almost 3 years ago
- Status changed from New to Ready For Testing
- Assignee set to Chris Roberts
- Pull request https://github.com/Katello/katello/pull/10123 added
Updated by The Foreman Bot almost 3 years ago
- Fixed in Releases Katello 4.5.0 added
Updated by Chris Roberts almost 3 years ago
- Status changed from Ready For Testing to Closed
Applied in changeset katello|a65daa6c7baf11be9b5a75f4de3e6d462ffd952d.
Updated by The Foreman Bot almost 3 years ago
- Pull request https://github.com/Katello/katello/pull/10152 added