Bug #34659
closed
Katello bookmark icon should be consistent with Foreman's
Added by Jeremy Lenz over 2 years ago.
Updated about 2 years ago.
Description
Right now Foreman uses the correct bookmark icon (white outline) and Katello uses the incorrect one (solid black). I think there were reasons for this, but I can't recall and anyway we should standardize it.
Files
- Target version set to Katello 4.5.0
- Triaged changed from No to Yes
"I think there were reasons for this"
Indeed!
So, patternfly uses Font Awesome for their icon library. By default (and perhaps by design) only icons built with the "fas" or fa-solid style are supported, and thus why all patternfly components are using using "fas"/solid styled font-awesome icons. The iconography style/library for the "correct bookmark icon (white outline)" mentioned above would use the "far" or fa-regular font awesome library not supported out of the box from Patternfly.
To be consistent with Patternfly (not foreman), the choice was made when initially designing the bookmark functionality to use the iconography as supported by Patternfly. This was approved by design before applying.
- Status changed from New to Ready For Testing
- Assignee set to Chris Roberts
- Pull request https://github.com/Katello/katello/pull/10123 added
- Fixed in Releases Katello 4.5.0 added
- Status changed from Ready For Testing to Closed
- Pull request https://github.com/Katello/katello/pull/10152 added
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by 
Updated by