Bug #34659: Katello bookmark icon should be consistent with Foreman's - Katello - Foreman

Actions

Copy link

Bug #34659

closed

Katello bookmark icon should be consistent with Foreman's

Added by Jeremy Lenz about 3 years ago. Updated almost 3 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Chris Roberts

Category:

Web UI

Target version:

Katello 4.5.0

Difficulty:

Triaged:

Yes

Bugzilla link:

Pull request:

https://github.com/Katello/katello/pull/10123, https://github.com/Katello/katello/pull/10152

Fixed in Releases:

Katello 4.5.0

Found in Releases:

Red Hat JIRA:

Description

Right now Foreman uses the correct bookmark icon (white outline) and Katello uses the incorrect one (solid black). I think there were reasons for this, but I can't recall and anyway we should standardize it.

Files

foreman_bookmarks.png	View foreman_bookmarks.png	6.51 KB	bookmark icon from HW Models page	Jeremy Lenz, 03/21/2022 08:20 PM
black_bookmark.png	View black_bookmark.png	2.03 KB	bookmark icon from Repository sets	Jeremy Lenz, 03/21/2022 08:20 PM

Actions

Copy link

Updated by Andrew Dewar about 3 years ago

"I think there were reasons for this"

Indeed!
So, patternfly uses Font Awesome for their icon library. By default (and perhaps by design) only icons built with the "fas" or fa-solid style are supported, and thus why all patternfly components are using using "fas"/solid styled font-awesome icons. The iconography style/library for the "correct bookmark icon (white outline)" mentioned above would use the "far" or fa-regular font awesome library not supported out of the box from Patternfly.

To be consistent with Patternfly (not foreman), the choice was made when initially designing the bookmark functionality to use the iconography as supported by Patternfly. This was approved by design before applying.