Project

General

Profile

Actions
Copy link

Bug #34772

closed

validate_supported_address issue

Added by Yoann Moulin over 2 years ago. Updated about 2 years ago.

Status:
Duplicate
Priority:
High
Assignee:
-
Category:
-
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

Hello,

we have deployed foreman stable-3.2 and we found a bug.

Calls of the function validate_supported_address has been added with multiple arguments1 in this commit fixes "#18069 - Add ip/mac Addr. validations (DHCP)"

1. https://github.com/theforeman/smart-proxy/blob/9909e3ad34c98e6771e1555de274bea640014c75/modules/dhcp/dhcp_api.rb#L63

But the function itself2 still required only one

2. https://github.com/theforeman/smart-proxy/blob/9909e3ad34c98e6771e1555de274bea640014c75/modules/dhcp_common/server.rb#L32

an update of the function3 is available in the dev branch

3. https://github.com/theforeman/smart-proxy/blob/ef07230a136494f560e99d4d1de8c3caed02acca/modules/dhcp_common/server.rb

Best regards,

Yoann

Related issues 2 (0 open — 2 closed)

Related to Packaging - Bug #19069: DNS and DHCP providers for libvirt fail to startResolved03/29/2017Actions
Related to Smart Proxy - Bug #34359: DHCP error with wrong number of arguments for validate_supported_addressClosedLukas ZapletalActions
Actions
Copy link
 #2

Updated by Ewoud Kohl van Wijngaarden about 2 years ago

  • Related to Bug #19069: DNS and DHCP providers for libvirt fail to start added
Actions
Copy link
 #3

Updated by Ewoud Kohl van Wijngaarden about 2 years ago

  • Related to Bug #34359: DHCP error with wrong number of arguments for validate_supported_address added
Actions
Copy link
 #4

Updated by Ewoud Kohl van Wijngaarden about 2 years ago

  • Status changed from New to Duplicate

Looks like this was fixed in #34359, but we didn't properly cherry pick to 3.2. I think that was my mistake. So it is fixed in 3.1.2 and 3.3.0. I've aligned it to 3.2.2. Closing as a duplicate now.

Actions
Copy link

Also available in: Atom PDF