Project

General

Profile

Bug #34802

Tabbable latest version 5.3.1 is not compatible with jest dom/ JSDom without changes to PF4.

Added by Samir Jha 2 months ago. Updated 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Web Interface
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

From my debugging and googling, the latest version of Tabbable that is 5.3.0 (and onwards) needs some changes to the Modal/Wizard components in Patternfly4 to be able to support tests.

Specifically this: https://github.com/focus-trap/tabbable#testing-in-jsdom

Modal currently has the prop disableFocusTrap that can be set to false and that lets us work around the issue without ever activating the trap. I spoke to folks on PF4 slack and they lock the version of FocusTrap but Focustrap brings in the latest 5.x.x tabbable causing the test failures.

There's an open PF4 issue around this: https://github.com/patternfly/patternfly-react/issues/7288

Associated revisions

Revision 86b63fd6 (diff)
Added by Samir Jha 2 months ago

Fixes #34802 - Pin tabbable version

History

#1 Updated by The Foreman Bot 2 months ago

  • Assignee set to Samir Jha
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/9195 added

#2 Updated by The Foreman Bot 2 months ago

  • Pull request https://github.com/theforeman/foreman-js/pull/398 added

#3 Updated by The Foreman Bot 2 months ago

  • Fixed in Releases 3.3.0 added

#4 Updated by Anonymous 2 months ago

  • Status changed from Ready For Testing to Closed

#5 Updated by Samir Jha 2 months ago

  • Pull request deleted (https://github.com/theforeman/foreman-js/pull/398)

#6 Updated by Samir Jha 2 months ago

  • Bugzilla link set to 2078983

Also available in: Atom PDF