Actions
Bug #34802
closed
Tabbable latest version 5.3.1 is not compatible with jest dom/ JSDom without changes to PF4.
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
Description
From my debugging and googling, the latest version of Tabbable that is 5.3.0 (and onwards) needs some changes to the Modal/Wizard components in Patternfly4 to be able to support tests.
Specifically this: https://github.com/focus-trap/tabbable#testing-in-jsdom
Modal currently has the prop disableFocusTrap that can be set to false and that lets us work around the issue without ever activating the trap. I spoke to folks on PF4 slack and they lock the version of FocusTrap but Focustrap brings in the latest 5.x.x tabbable causing the test failures.
There's an open PF4 issue around this: https://github.com/patternfly/patternfly-react/issues/7288
Updated by The Foreman Bot about 2 years ago
- Status changed from New to Ready For Testing
- Assignee set to Samir Jha
- Pull request https://github.com/theforeman/foreman/pull/9195 added
Updated by The Foreman Bot about 2 years ago
- Pull request https://github.com/theforeman/foreman-js/pull/398 added
Updated by Anonymous about 2 years ago
- Status changed from Ready For Testing to Closed
Applied in changeset foreman|86b63fd66254f5565000bac885dae0e947835952.
Updated by Samir Jha almost 2 years ago
- Pull request deleted (
https://github.com/theforeman/foreman-js/pull/398)
Actions