Project

General

Profile

Actions

Bug #3516

closed

Architectures etc: resources created/modified should not use multibyte names in URLs

Added by Dominic Cleal almost 11 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
High
Assignee:
-
Category:
Web Interface
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

When creating resources (such as architectures) with multibyte names, the full unicode characters are used in resource URLs instead of being run through .parameterize to only include URL-safe chars.

Compare this with compute resources, where URLs containing resource names have URL-unsafe chars stripped out due to .parameterize.

(https://bugzilla.redhat.com/show_bug.cgi?id=1023062)


Related issues 2 (0 open2 closed)

Related to Foreman - Feature #4386: implement gem friendly_id to simply find by id, name, label, etcClosedJoseph Magen02/19/2014Actions
Has duplicate Foreman - Bug #3600: Bookmarks with "/" in Name Break Bookmarks PageDuplicateStephen Benjamin11/07/201311/07/2013Actions
Actions #1

Updated by Dominic Cleal almost 11 years ago

  • Priority changed from Normal to High
  • Target version set to 1.15.0

This can also severely break the UI if a resource is created with a "/" in its name, e.g. a domain. The example in the report below isn't required, just entering "a/b" is sufficient.

Steps to Reproduce:
1. Navigate to Domains in foreman and try to create a new domain. use the following string

你好/`cat /etc/passwd/

2. Note error
3. Attempt to navigate back to main domains UI at all, e.g., server.example.com/foreman/domains

Actual results:

Initial and subsequent errors

"Oops, we're sorry but something went wrong

x No route matches {:action=>"edit", :controller=>"domains", :id=>"你好/`cat /etc/passwd/`"}
If you feel this is an error with Foreman itself, please open a new issue with Foreman ticketing system, You would probably need to attach the Full trace and relevant log entries.

Back"

User cannot access page

Expected results:
Field validation

Workaround: use the CLI or API to remove it.

(https://bugzilla.redhat.com/show_bug.cgi?id=1023093)

Actions #2

Updated by Anonymous almost 11 years ago

  • Status changed from New to Assigned
  • Assignee set to Anonymous
Actions #3

Updated by Anonymous almost 11 years ago

  • Status changed from Assigned to Ready For Testing
Actions #4

Updated by Dominic Cleal almost 11 years ago

  • Has duplicate Bug #3600: Bookmarks with "/" in Name Break Bookmarks Page added
Actions #5

Updated by Anonymous almost 11 years ago

  • Target version changed from 1.15.0 to 1.10.0
Actions #6

Updated by Dominic Cleal almost 11 years ago

  • Translation missing: en.field_release set to 2
Actions #7

Updated by Anonymous almost 11 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #8

Updated by Dominic Cleal over 10 years ago

  • Related to Feature #4386: implement gem friendly_id to simply find by id, name, label, etc added
Actions

Also available in: Atom PDF