Refactor #35196
Use assert_equal in rendered template snapshots
Description
The current code uses assert false, "Rendered template ..."
but this doesn't show you exactly what's wrong in a report like on Jenkins. By using assert_equal a diff is shown in the report.
Associated revisions
History
#1
Updated by The Foreman Bot 9 months ago
- Assignee set to Ewoud Kohl van Wijngaarden
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/9300 added
#2
Updated by The Foreman Bot 9 months ago
- Pull request https://github.com/theforeman/foreman/pull/9295 added
#3
Updated by The Foreman Bot 8 months ago
- Fixed in Releases 3.4.0 added
#4
Updated by Oleh Fedorenko 8 months ago
- Pull request deleted (
https://github.com/theforeman/foreman/pull/9295)
#5
Updated by Oleh Fedorenko 8 months ago
- Status changed from Ready For Testing to Closed
Fixes #35196 - Use assert_equal to match rendered templates
This allows the report to properly show up in Jenkins, rather than the
unhelpful message that it didn't match.