Project

General

Custom queries

Profile

Actions
Copy link

Refactor #35196

closed

Use assert_equal in rendered template snapshots

Added by Ewoud Kohl van Wijngaarden almost 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ewoud Kohl van Wijngaarden
Category:
Tests
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/9300
Fixed in Releases:
3.4.0
Found in Releases:
Red Hat JIRA:

Description

The current code uses assert false, "Rendered template ..." but this doesn't show you exactly what's wrong in a report like on Jenkins. By using assert_equal a diff is shown in the report.

Actions
Copy link
 #1

Updated by The Foreman Bot almost 3 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Ewoud Kohl van Wijngaarden
  • Pull request https://github.com/theforeman/foreman/pull/9300 added
Actions
Copy link
 #2

Updated by The Foreman Bot almost 3 years ago

  • Pull request https://github.com/theforeman/foreman/pull/9295 added
Actions
Copy link
 #3

Updated by The Foreman Bot almost 3 years ago

  • Fixed in Releases 3.4.0 added
Actions
Copy link
 #4

Updated by Oleh Fedorenko almost 3 years ago

  • Pull request deleted (https://github.com/theforeman/foreman/pull/9295)
Actions
Copy link
 #5

Updated by Oleh Fedorenko almost 3 years ago

  • Status changed from Ready For Testing to Closed
Actions
Copy link

Also available in: Atom PDF