Project

General

Profile

Actions

Bug #35301

closed

minitest raises deprecation warnings about global use

Added by Ewoud Kohl van Wijngaarden over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Category:
Tests
Target version:
-
Difficulty:
Triaged:
No
Fixed in Releases:
Found in Releases:

Description

In minitest 6 it will be invalid to use object.must_include(item). It should instead use _(object).must_include(item). This method name overlaps with `_()` from gettext. There is a hack to work around this, but it's also possible to call value() or use assert_includes(collection, value). When using Rails 7 and Ruby 3.1 our hack no longer appears to work so the alternatives are better.

Actions #1

Updated by The Foreman Bot over 1 year ago

  • Status changed from New to Ready For Testing
  • Assignee set to Ewoud Kohl van Wijngaarden
  • Pull request https://github.com/theforeman/foreman/pull/9333 added
Actions #2

Updated by The Foreman Bot over 1 year ago

  • Fixed in Releases 3.4.0 added
Actions #3

Updated by Ewoud Kohl van Wijngaarden over 1 year ago

  • Status changed from Ready For Testing to Closed
Actions

Also available in: Atom PDF