Bug #35301: minitest raises deprecation warnings about global use - Foreman

Actions

Copy link

Bug #35301

closed

minitest raises deprecation warnings about global use

Added by Ewoud Kohl van Wijngaarden almost 3 years ago. Updated almost 3 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Ewoud Kohl van Wijngaarden

Category:

Tests

Target version:

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/9333

Fixed in Releases:

3.4.0

Found in Releases:

Red Hat JIRA:

Description

In minitest 6 it will be invalid to use object.must_include(item). It should instead use _(object).must_include(item). This method name overlaps with `_()` from gettext. There is a hack to work around this, but it's also possible to call value() or use assert_includes(collection, value). When using Rails 7 and Ruby 3.1 our hack no longer appears to work so the alternatives are better.