Project

General

Profile

Bug #35364

When installing errata via katello-agent, content_action_finish_timeout is ignored and tasks don't wait for client status to finish

Added by Joniel Pasqualetto 4 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Category:
Tooling
Target version:
Difficulty:
Triaged:
Yes
Bugzilla link:
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

Description of problem:

When installing errata via katello-agent, task ends with success for any task that is fetched by gofer and don't end within content_action_accept_timeout.

So, for example a task to install errata on a host will start and if it doesn't fail in 20 seconds (default value for content_action_accept_timeout), the task will end with success. If the task fails on the client side after 20 seconds, satellite would not know.

Version-Release number of selected component (if applicable):

Satellite 6.10.7
Probably also affects 6.11, but didn't test it.

Steps to Reproduce:

1. Setup a Satellite 6.10 having katello-agent capabilities

2. Start an errata installation task which will take more than 20 seconds to finish (or modify the content_action_accept_timeout to a lower value).

3. Observe that in 20 seconds, while the task is still running on the client, on Satellite it will be already finished with success.

Extra test: start a task that will take more than 20 seconds to FAIL. In 20 seconds, the task on satellite will be marked as success independently of what really happened to it on the client.

Extra info: if the task fails, on the host, in less than 20 seconds then Satellite will get the correct status.

Actual results:

Tasks end with success in 20 seconds (only condition for success is the host to get the task from its queue) independently of the actual result on the host.

Expected results:

Task should wait content_action_finish_timeout for the host to send the actual output of the task.

Additional info:

Associated revisions

Revision fe90a5c6 (diff)
Added by Samir Jha 3 months ago

Fixes #35364 - Wait for content_action_finish_timeout or the task-result (#10278)

  • Fixes #35364 - Wait for content_action_finish_timeout or the task-result
  • Fixes #35364 - Fix tests for the PR

Co-authored-by: Joniel Pasqualetto <>

History

#1 Updated by The Foreman Bot 4 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/10233 added

#2 Updated by Chris Roberts 4 months ago

  • Triaged changed from No to Yes
  • Target version set to Katello 4.6.0
  • Assignee set to Joniel Pasqualetto
  • Category set to Tooling

#3 Updated by Samir Jha 3 months ago

  • Triaged changed from Yes to No

#4 Updated by Jeremy Lenz 3 months ago

  • Triaged changed from No to Yes
  • Target version changed from Katello 4.6.0 to Katello 4.7.0

#5 Updated by The Foreman Bot 3 months ago

  • Pull request https://github.com/Katello/katello/pull/10278 added

#6 Updated by Samir Jha 3 months ago

  • Pull request deleted (https://github.com/Katello/katello/pull/10233)

#7 Updated by The Foreman Bot 3 months ago

  • Fixed in Releases Katello 4.7.0 added

#8 Updated by Samir Jha 3 months ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF