Feature #35375: db:seed should run on every upgrade even if there are no changes to seed files directly - Foreman

Actions

Copy link

Feature #35375

closed

db:seed should run on every upgrade even if there are no changes to seed files directly

Added by Samir Jha almost 4 years ago. Updated 5 months ago.

Status:

Closed

Priority:

Normal

Assignee:

Bernhard Suttner

Category:

Target version:

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/10858

Fixed in Releases:

3.19.0

Found in Releases:

Red Hat JIRA:

Description

Today the foreman_seeder.rb : https://github.com/theforeman/foreman/blob/c3c697fa131aa54c11918bcc563a7789f3c08ef7/app/services/foreman_seeder.rb#L40
checks if any seed files have changed to run/skip seeding. This is not ideal as any changes to helper methods are not considered when deciding whether to run/skip seeding.

We should probably delete the Foreman.internal record pre-upgrade to make sure db:seed runs during all upgrades.

Actions

Copy link

Updated by Ewoud Kohl van Wijngaarden almost 4 years ago

Status changed from New to Rejected

We've moved the responsibility to seed into Foreman and simply call a rake task to check if we need to seed. I'm going to reject this from the installer's perspective. If you want to solve this, solve it in Foreman or the plugin itself.

If you run into this and want to force seeding, make sure the hash of a file changes. That can be done by adding a comment in it.

Actions

Copy link