Refactor #3540
open
Change pluck('table.column') back to pluck(:column)
Added by Dominic Cleal about 11 years ago.
Updated about 9 years ago.
Description
For Rails 3.2.8 compatibility, we've changed a few instance of pluck(:column) to specify the table name to remove ambiguity (which 3.2.13 and higher can cope with). These can be reverted on Rails 4 or similar.
b1e56e3c62535fd89ed4e226c56961cb5e8a3e3e #3538
65f764d6081b04cd03fa56a78e6281b5221b0bac #2579
- Subject changed from Change pluck('table.column') back to pluck('column') to Change pluck('table.column') back to pluck(:column')
- Description updated (diff)
Oops, thanks Petr. The string was laziness, I hadn't realised it was different!
- Subject changed from Change pluck('table.column') back to pluck(:column') to Change pluck('table.column') back to pluck(:column)
- Description updated (diff)
- Translation missing: en.field_release set to 21
- Translation missing: en.field_release deleted (
21)
I'm not sure I want this.
specifying the table name in situations where there's a join makes a lot of sense to me. it's more verbose, and feels right to me. let's keep it like it is.
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/2639 added
- Pull request deleted (
- Status changed from Ready For Testing to New
- Pull request deleted (
https://github.com/theforeman/foreman/pull/2639)
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by 
Updated by 
Updated by