Project

General

Profile

Bug #3551

Foreman removes all puppet classes from a hostgroup when the environment is changed.

Added by Jim Bailey over 8 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Sebastian Gräßl
Category:
Puppet integration
Target version:
1.15.0
Difficulty:
Triaged:
Bugzilla link:
1158991
Pull request:
https://github.com/theforeman/foreman/pull/4048
Fixed in Releases:
Found in Releases:

Description

When changing the environment for a hostgroup, puppet removes all classes.

Related issues

Related to Foreman - Bug #18045: Puppet classes don't show up without hostgroupsClosed2017-01-12
Related to Foreman - Bug #18427: Hostgroups don't have any puppet classes (or are removed upon editing a hostgroup)Resolved2017-02-08

Associated revisions

Revision 915ee077 (diff)
Added by Sebastian Gräßl over 5 years ago

Fixes #3551 - Show unavailable Puppet Classes in Host Group edit

Puppet Classes can be assigned to a Host Group even if they are
not available in the set environment.

The Classes persist through out changes of the environment,
but were previously hidden from the UI this changes that.

Unavailable Puppet Classes are now shown in the UI as greyed out
and a warning is displayed to inform the user about them.

History

#1 Updated by Dominic Cleal over 7 years ago

  • Category set to Puppet integration

#2 Updated by Dominic Cleal over 7 years ago

  • Bugzilla link set to 1158991

#3 Updated by Sebastian Gräßl over 5 years ago

The circumstances under which this occurs are when a class are not available in the environment the `HostGroup` will be changed to.
If the target environment does have the class available it will be kept. This does not happen instantly (anymore) but requires the form to be submitted.

Since Foreman does not create classes in puppet, but only reflect what is in puppet, keeping the classes in host groups as they are could lead to confusion, if they are not actually in the current environment. Keeping them, and marking them as "unavailable" if the environment does not include it and allow to remove them manually.

A simpler approach would be to simple warn in case classes are not available and will be purged on submit.

Thoughts on which route would be the more feasible way to go?

#4 Updated by Marek Hulán over 5 years ago

I prefer warning about purging on submit.

#5 Updated by Sebastian Gräßl over 5 years ago

  • Assignee set to Sebastian Gräßl

#6 Updated by Marek Hulán over 5 years ago

  • Target version set to 1.4.4

#7 Updated by The Foreman Bot over 5 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4048 added

#8 Updated by Tomáš Strachota over 5 years ago

  • Target version deleted (1.4.4)

#9 Updated by Daniel Lobato Garcia over 5 years ago

  • Target version set to 1.15.5

#10 Updated by Anonymous over 5 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#11 Updated by Dominic Cleal over 5 years ago

  • Legacy Backlogs Release (now unused) set to 209

#12 Updated by Dominic Cleal over 5 years ago

  • Related to Bug #18045: Puppet classes don't show up without hostgroups added

#13 Updated by Daniel Lobato Garcia over 5 years ago

  • Target version changed from 1.15.5 to 169

#14 Updated by Dominic Cleal over 5 years ago

  • Related to Bug #18427: Hostgroups don't have any puppet classes (or are removed upon editing a hostgroup) added

#15 Updated by Brad Buckingham over 5 years ago

  • Target version deleted (169)

#16 Updated by Daniel Lobato Garcia over 5 years ago

  • Target version set to 1.11.0

Also available in: Atom PDF