Bug #35684
closed
Filter "Applied catalog in x.y seconds" messages out of Puppet report
Description
We filter out "Finished catalog run in x.y seconds" but somewhere between Puppet report format version 3 and 6 the message changed to "Applied catalog in x.y seconds". This is then stored in the DB while it's also reported as a metric. It should be filtered out again.
Updated by The Foreman Bot about 2 years ago
- Status changed from New to Ready For Testing
- Assignee set to Ewoud Kohl van Wijngaarden
- Pull request https://github.com/theforeman/puppet-puppetserver_foreman/pull/25 added
Updated by Ewoud Kohl van Wijngaarden about 2 years ago
- Status changed from Ready For Testing to Closed
- Triaged changed from No to Yes
- Fixed in Releases 3.5.0 added
Updated by Ewoud Kohl van Wijngaarden almost 2 years ago
Looks like this caused a regression: if there is no log entry, Foreman can't determine the source of the report. See https://community.theforeman.org/t/identify-config-report-origin/31465 for more details.
Updated by Ewoud Kohl van Wijngaarden almost 2 years ago
- Related to Bug #35833: Puppet configuration reports without entries do not get an origin added
Updated by Antonin Dvorak almost 2 years ago
Hello,
related to this ticket - I run Puppet 5 and Foreman 3.5.
With this change "Applied catalog in x.y seconds" are indeed not displayed in Foreman Puppet reports, however the Report Status still shows 1 applied event -> hosts fall into the "Hosts that had performed modifications without error" when they have not done any real changes.
Any tips what to do with this? Some global "report_status["applied"] -= 1" ? Or decrease of the counter when "if log.message =~ /^(Finished catalog run|Applied catalog) in \d+.\d+ seconds$/" is triggered?
I know Puppet 5 is no longer supported from Foreman's side, but I have no way how to verify if it applies only to this older version.
Thank you.