Project

General

Profile

Bug #3569

Port in use by the browser is used in rendering the templates

Added by Greg Sutcliffe about 5 years ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Category:
Unattended installations
Target version:
Difficulty:
Triaged:
Bugzilla link:
Pull request:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

We fixed the hostname version of this issue a while back, but the port got missed. If you use a non-standard port to access foreman, it'll be written into your templates, which makes tunnelling in from home a real pain.

We should update :foreman_url to be a real url and then parse it for the host and port


Related issues

Related to Foreman - Bug #3210: We set foreman_url to foreman.domain by defaultClosed2013-10-08
Related to Foreman - Feature #717: Add an option to overwrite foreman_url value for reverse proxy useResolved2011-03-08
Has duplicate Foreman - Bug #2559: in foreman_url() Port is still copied from users browserClosed2013-05-24
Has duplicate Foreman - Bug #1461: preseed URL hardcoded to http (patch)Resolved2012-01-20
Precedes Foreman - Bug #3659: "no implicit conversion of URI::HTTP into String" running rake reports:summarizeClosed2013-11-052013-11-05

Associated revisions

Revision 8c618ae8 (diff)
Added by Greg Sutcliffe about 5 years ago

Fixes #3569, #3210 - Use port from foreman_url for templates

Revision ce188941 (diff)
Added by Dominic Cleal about 5 years ago

refs #3569 - fix URL validation test error on merge

History

#1 Updated by Dominic Cleal about 5 years ago

  • Status changed from Assigned to Ready For Testing

#2 Updated by Dominic Cleal about 5 years ago

  • Assignee set to Greg Sutcliffe

#3 Updated by Greg Sutcliffe about 5 years ago

  • Has duplicate Bug #2559: in foreman_url() Port is still copied from users browser added

#4 Updated by Dominic Cleal about 5 years ago

  • Related to Bug #3210: We set foreman_url to foreman.domain by default added

#5 Updated by Dominic Cleal about 5 years ago

  • Legacy Backlogs Release (now unused) set to 2

#6 Updated by Greg Sutcliffe about 5 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#7 Updated by Dominic Cleal about 5 years ago

  • Has duplicate Bug #1461: preseed URL hardcoded to http (patch) added

#8 Updated by Dominic Cleal about 5 years ago

  • Related to Feature #717: Add an option to overwrite foreman_url value for reverse proxy use added

#9 Updated by Dominic Cleal about 5 years ago

  • Precedes Bug #3659: "no implicit conversion of URI::HTTP into String" running rake reports:summarize added

Also available in: Atom PDF