Project

General

Profile

Actions

Feature #35696

closed

Add BIOS info to reported data facet

Added by Karolína Małyjurková almost 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Category:
Facts
Target version:
-
Difficulty:
Triaged:
Yes
Fixed in Releases:
Found in Releases:

Description

In order to show BIOS facts in HOST_DETAILS of the selected host the data needs to be stored as a reported data facet.

Actions #1

Updated by Ewoud Kohl van Wijngaarden almost 2 years ago

Note that facts can widely vary, depending on the source. We have reported data, which is a normalized version of it. That makes it reliable to use in the UI and is part of the API. See #35619 as well for how a kernel_version fact was added and then consumed in #35622.

Actions #2

Updated by Karolína Małyjurková almost 2 years ago

Thank you for your response. However, we would like to merge PR #35667 by the end of the next week, and I think your resolve would need someone else to do it. Is the way I approach it not suitable?

Actions #3

Updated by Ewoud Kohl van Wijngaarden almost 2 years ago

No, facts are too different. Depending on the fact source it can be reported with a very different name and it's very unpredictable. We really need to normalize it into reported data first.

Actions #4

Updated by Karolína Małyjurková almost 2 years ago

Sure, thank you for your help.

Actions #5

Updated by The Foreman Bot almost 2 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/9497 added
Actions #6

Updated by The Foreman Bot almost 2 years ago

  • Fixed in Releases 3.5.0 added
Actions #7

Updated by Ewoud Kohl van Wijngaarden almost 2 years ago

  • Subject changed from Add facts to the host API to Add BIOS info to reported data facet
  • Description updated (diff)
Actions #8

Updated by Maria Agaphontzev almost 2 years ago

  • Status changed from Ready For Testing to Closed
Actions #9

Updated by Ewoud Kohl van Wijngaarden almost 2 years ago

  • Category changed from API to Facts
  • Triaged changed from No to Yes
Actions

Also available in: Atom PDF