Project

General

Profile

Actions

Refactor #35717

closed

use caller_locations when emiting deprecation warnings

Added by Evgeni Golov over 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Rails
Target version:
-
Difficulty:
Triaged:
Yes
Fixed in Releases:
Found in Releases:

Description

Current code emits a warning when trying to emit a deprecation warning:

ActiveSupport::DeprecationException: DEPRECATION WARNING: Please pass `caller_locations` to the deprecation API (called from deprecation_warning at foreman/app/services/foreman/deprecation.rb:6)
caller_locations was added in Ruby 2.0, so uh, it's safe to use by now ;-)

The above warning comes from Rails at https://github.com/rails/rails/blob/6-1-stable/activesupport/lib/active_support/deprecation/reporting.rb#L138 - and has been there since Rails 5, no idea why we stumble only now over it.

Actions #1

Updated by The Foreman Bot over 1 year ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/9499 added
Actions #2

Updated by Evgeni Golov over 1 year ago

  • Description updated (diff)
Actions #3

Updated by The Foreman Bot over 1 year ago

  • Fixed in Releases 3.5.0 added
Actions #4

Updated by Evgeni Golov over 1 year ago

  • Status changed from Ready For Testing to Closed
Actions #5

Updated by Ewoud Kohl van Wijngaarden about 1 year ago

  • Triaged changed from No to Yes
Actions

Also available in: Atom PDF