Project

General

Profile

Refactor #35717

use caller_locations when emiting deprecation warnings

Added by Evgeni Golov 25 days ago. Updated 1 day ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Rails
Target version:
-
Difficulty:
Triaged:
Yes
Bugzilla link:
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

Current code emits a warning when trying to emit a deprecation warning:

ActiveSupport::DeprecationException: DEPRECATION WARNING: Please pass `caller_locations` to the deprecation API (called from deprecation_warning at foreman/app/services/foreman/deprecation.rb:6)
caller_locations was added in Ruby 2.0, so uh, it's safe to use by now ;-)

The above warning comes from Rails at https://github.com/rails/rails/blob/6-1-stable/activesupport/lib/active_support/deprecation/reporting.rb#L138 - and has been there since Rails 5, no idea why we stumble only now over it.

Associated revisions

Revision df2bbe1f (diff)
Added by Evgeni Golov 25 days ago

Fixes #35717 - use caller_locations in deprecation warnings

Rails prefers to have it that way for better reporting

History

#1 Updated by The Foreman Bot 25 days ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/9499 added

#2 Updated by Evgeni Golov 25 days ago

  • Description updated (diff)

#3 Updated by The Foreman Bot 25 days ago

  • Fixed in Releases 3.5.0 added

#4 Updated by Evgeni Golov 25 days ago

  • Status changed from Ready For Testing to Closed

#5 Updated by Ewoud Kohl van Wijngaarden 1 day ago

  • Triaged changed from No to Yes

Also available in: Atom PDF