Bug #35744
closed
React-intl components are not translated
Description
Every component that uses react-intl (mostly dates and relative times) doesnt get translated, for example: Last login time data in users table, boot time in host details, details, Operating system card.
Error:
[React Intl] Missing locale data for locale: "ru". Using default locale: "en" as fallback.
Updated by The Foreman Bot almost 2 years ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/9508 added
Updated by Ewoud Kohl van Wijngaarden almost 2 years ago
It helps me to determine cherry picks if you set Found in Releases. Looking a the PR I think this has been there for a while. Alternatively, if you can point to a specific commit that introduced it I also often use Fixes: COMMIT (see 36f2892adfa19b84fbb52d1fb017e10922075f97 for an example). Then it's also easy to see with git tag --contains COMMIT in which release it was introduced.
Updated by Maria Agaphontzev almost 2 years ago
I dont know how long do react dates have not been working (or if they were ever working) but I checked and it wasn't working in 2.1, and specifically the date in the users table was replaced from ruby to react in 2.5 and stopped working there.
Updated by Ewoud Kohl van Wijngaarden almost 2 years ago
- Target version set to 3.4.1
Well, that does help since it effectively means all supported releases. I'm planning to release 3.4.1 next week so I'll probably wait for this.
Updated by Maria Agaphontzev almost 2 years ago
- Status changed from Ready For Testing to Closed
Applied in changeset foreman|16f370ccc20427a4b9895570be1ee082c87c7ffd.
Updated by The Foreman Bot almost 2 years ago
- Pull request https://github.com/theforeman/foreman/pull/9552 added
Updated by Ewoud Kohl van Wijngaarden almost 2 years ago
- Target version changed from 3.4.1 to 3.4.2
- Triaged changed from No to Yes
- Fixed in Releases deleted (
3.6.0)