Bug #35744: React-intl components are not translated - Foreman

Bug #35744

React-intl components are not translated

Added by Maria Agaphontzev 3 months ago. Updated about 2 months ago.

Status:

Closed

Priority:

Normal

Assignee:

Maria Agaphontzev

Category:

Internationalization

Target version:

3.4.2

Difficulty:

Triaged:

Yes

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/9552, https://github.com/theforeman/foreman/pull/9508

Fixed in Releases:

3.5.0

Found in Releases:

Red Hat JIRA:

Description

Every component that uses react-intl (mostly dates and relative times) doesnt get translated, for example: Last login time data in users table, boot time in host details, details, Operating system card.
Error:

[React Intl] Missing locale data for locale: "ru". Using default locale: "en" as fallback.

Associated revisions

Revision 16f370cc (diff)
Added by Maria Agaphontzev about 2 months ago

Fixes #35744 - Date components are not translated

History

#1 Updated by The Foreman Bot 3 months ago

Status changed from New to Ready For Testing
Pull request https://github.com/theforeman/foreman/pull/9508 added

#2 Updated by Ewoud Kohl van Wijngaarden 3 months ago

It helps me to determine cherry picks if you set Found in Releases. Looking a the PR I think this has been there for a while. Alternatively, if you can point to a specific commit that introduced it I also often use Fixes: COMMIT (see 36f2892adfa19b84fbb52d1fb017e10922075f97 for an example). Then it's also easy to see with git tag --contains COMMIT in which release it was introduced.

#3 Updated by Maria Agaphontzev 3 months ago

I dont know how long do react dates have not been working (or if they were ever working) but I checked and it wasn't working in 2.1, and specifically the date in the users table was replaced from ruby to react in 2.5 and stopped working there.