Project

General

Profile

Actions

Bug #35797

closed

nic network/bridge comparison can be nil

Added by Ben Magistro over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Compute resources - libvirt
Target version:
-
Difficulty:
Triaged:
Yes
Fixed in Releases:
Found in Releases:

Description

When provisioning a VM with a bridge and sriov passthrough, the nic iteration may compare nil to nil resulting in random mac address being associated with the interface and boot/discovery not working as expected.

Nov 19 14:26:32 provisioning foreman[22162]: Comparing networks --   <Fog::Libvirt::Compute::Nic
Nov 19 14:26:32 provisioning foreman[22162]: mac="52:54:00:f8:65:09",
Nov 19 14:26:32 provisioning foreman[22162]: id=nil,
Nov 19 14:26:32 provisioning foreman[22162]: type="bridge",
Nov 19 14:26:32 provisioning foreman[22162]: network=nil,
Nov 19 14:26:32 provisioning foreman[22162]: bridge="br-vm-mgmt",
Nov 19 14:26:32 provisioning foreman[22162]: model="virtio" 
Nov 19 14:26:32 provisioning foreman[22162]: > to {"type"=>"bridge", "bridge"=>"br-vm-mgmt", "model"=>"virtio"}
Nov 19 14:26:32 provisioning foreman[22162]: Comparing networks --  to
Nov 19 14:26:32 provisioning foreman[22162]: Found

Nov 19 14:26:32 provisioning foreman[22162]: Comparing networks --   <Fog::Libvirt::Compute::Nic
Nov 19 14:26:32 provisioning foreman[22162]: mac="52:54:00:cd:74:06",
Nov 19 14:26:32 provisioning foreman[22162]: id=nil,
Nov 19 14:26:32 provisioning foreman[22162]: type="network",
Nov 19 14:26:32 provisioning foreman[22162]: network="passthrough-p3p2",
Nov 19 14:26:32 provisioning foreman[22162]: bridge=nil,
Nov 19 14:26:32 provisioning foreman[22162]: model="virtio" 
Nov 19 14:26:32 provisioning foreman[22162]: > to {"type"=>"network", "network"=>"passthrough-p3p2", "bridge"=>"br-vm-mgmt", "model"=>"virtio"}
Nov 19 14:26:32 provisioning foreman[22162]: Comparing networks -- passthrough-p3p2 to passthrough-p3p2
Nov 19 14:26:32 provisioning foreman[22162]: Found

Nov 19 14:26:32 provisioning foreman[22162]: Comparing networks --   <Fog::Libvirt::Compute::Nic
Nov 19 14:26:32 provisioning foreman[22162]: mac="52:54:00:45:28:cf",
Nov 19 14:26:32 provisioning foreman[22162]: id=nil,
Nov 19 14:26:32 provisioning foreman[22162]: type="network",
Nov 19 14:26:32 provisioning foreman[22162]: network="passthrough-p3p2",
Nov 19 14:26:32 provisioning foreman[22162]: bridge=nil,
Nov 19 14:26:32 provisioning foreman[22162]: model="virtio" 
Nov 19 14:26:32 provisioning foreman[22162]: > to {"type"=>"network", "network"=>"passthrough-p3p2", "bridge"=>"br-vm-mgmt", "model"=>"virtio"}
Nov 19 14:26:32 provisioning foreman[22162]: Comparing networks -- passthrough-p3p2 to passthrough-p3p2
Nov 19 14:26:32 provisioning foreman[22162]: Found

Files

tfm-nics.png View tfm-nics.png 66.8 KB Ben Magistro, 11/30/2022 08:12 PM
virtmgr-nic1.png View virtmgr-nic1.png 73.7 KB Ben Magistro, 11/30/2022 08:12 PM
virtmgr-nic3.png View virtmgr-nic3.png 59 KB Ben Magistro, 11/30/2022 08:12 PM
virtmgr-nic2.png View virtmgr-nic2.png 58.3 KB Ben Magistro, 11/30/2022 08:12 PM
Actions #1

Updated by The Foreman Bot over 1 year ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/9526 added

Updated by Ben Magistro over 1 year ago

While testing/updating a revised patch, captured some screen shots from tfm and virt-manager showing the nics (macs) not mapping correctly so attaching them here for reference.

Actions #3

Updated by The Foreman Bot over 1 year ago

  • Fixed in Releases 3.6.0 added
Actions #4

Updated by Ben Magistro over 1 year ago

  • Status changed from Ready For Testing to Closed
Actions #5

Updated by Ewoud Kohl van Wijngaarden over 1 year ago

  • Triaged changed from No to Yes
Actions

Also available in: Atom PDF