Project

General

Profile

Actions

Bug #35802

closed

Host status and personal access token views use magic numbers for per_page

Added by Ewoud Kohl van Wijngaarden almost 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Category:
JavaScript stack
Target version:
-
Difficulty:
Triaged:
Yes
Fixed in Releases:
Found in Releases:

Description

It's bad practice to call the API list views with per_page=XX and then don't implement pagination (unless a specific number was actually wanted, like the last X audit entries). Instead the per_page=all feature should be used to retrieve all values.

Actions #1

Updated by The Foreman Bot almost 2 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Ewoud Kohl van Wijngaarden
  • Pull request https://github.com/theforeman/foreman/pull/9528 added
Actions #2

Updated by The Foreman Bot almost 2 years ago

  • Fixed in Releases 3.6.0 added
Actions #3

Updated by Ewoud Kohl van Wijngaarden almost 2 years ago

  • Status changed from Ready For Testing to Closed
Actions #4

Updated by Ewoud Kohl van Wijngaarden almost 2 years ago

  • Triaged changed from No to Yes
Actions

Also available in: Atom PDF