Project

General

Profile

Bug #35802

Host status and personal access token views use magic numbers for per_page

Added by Ewoud Kohl van Wijngaarden 4 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Category:
JavaScript stack
Target version:
-
Difficulty:
Triaged:
Yes
Bugzilla link:
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

It's bad practice to call the API list views with per_page=XX and then don't implement pagination (unless a specific number was actually wanted, like the last X audit entries). Instead the per_page=all feature should be used to retrieve all values.

Associated revisions

Revision d6935ace (diff)
Added by Ewoud Kohl van Wijngaarden 4 months ago

Fixes #35802 - Use per_page=all in the UI

The client code doesn't implement pagination so you actually want to
retrieve everything, rather than some magic high number.

Fixes: ec35c4d82e493574da0b55e0d52dd24dbc6b638f
Fixes: 1c02010e9d334c7449ada31c2292e2348a686777

History

#1 Updated by The Foreman Bot 4 months ago

  • Assignee set to Ewoud Kohl van Wijngaarden
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/9528 added

#2 Updated by The Foreman Bot 4 months ago

  • Fixed in Releases 3.6.0 added

#3 Updated by Ewoud Kohl van Wijngaarden 4 months ago

  • Status changed from Ready For Testing to Closed

#4 Updated by Ewoud Kohl van Wijngaarden 4 months ago

  • Triaged changed from No to Yes

Also available in: Atom PDF