Actions
Bug #35921
closedLogging to journal causes duplicate log entries to appear
Description
When log_file is set to JOURNAL, standard logs go to the system journal. However, journal also collects what smart-proxy writes to its STDOUT, leading to duplicate (duplicate in meaning, not in shape) logs being collected.
Jan 11 05:35:27 cheerful-narwhal.example.com foreman-proxy[7405]: accept: 192.168.122.182:42420 Jan 11 05:35:27 cheerful-narwhal.example.com foreman-proxy[7405]: Rack::Handler::WEBrick is invoked. Jan 11 05:35:27 cheerful-narwhal.example.com foreman-proxy[7405]: Started GET /features Jan 11 05:35:27 cheerful-narwhal.example.com foreman-proxy[7405]: Finished GET /features with 200 (3.36 ms) Jan 11 05:35:27 cheerful-narwhal.example.com smart-proxy[7405]: 192.168.122.182 - - [11/Jan/2023:05:35:27 EST] "GET /features HTTP/1.1" 200 71 Jan 11 05:35:27 cheerful-narwhal.example.com smart-proxy[7405]: - -> /features Jan 11 05:35:27 cheerful-narwhal.example.com foreman-proxy[7405]: close: 192.168.122.182:42420
Looks like we are setting webrick's AccessLog to an empty array for http endpoint, but not for the https one
Updated by The Foreman Bot over 1 year ago
- Status changed from Assigned to Ready For Testing
- Pull request https://github.com/theforeman/smart-proxy/pull/854 added
Updated by Adam Ruzicka over 1 year ago
- Status changed from Ready For Testing to Closed
Applied in changeset eea8cf68adbf4968e8e9bc3425126ad7979bcf6e.
Updated by Ewoud Kohl van Wijngaarden over 1 year ago
- Category set to Core
- Target version set to 3.7.0
- Triaged changed from No to Yes
While this is a bug, I'm not going to pick it to 3.6 given it's a fairly large change in behavior.
Actions