Ohad Levy wrote:

thats nice :) can you refactor it so it uses the normal host list? (instead of copy paste almost the same code?)

I have tried, but I am getting the following error:

ActionView::TemplateError (undefined method `hosts_controller?' for #<ActionView::Base:0x2b81609bcfc8>) on line #17 of app/views/hosts/_minilist.html.erb:
14: <% hosts.each do |host| ->
15: <tr class="<= cycle("even", "odd") ->">
16: <td>
17: <= check_box_tag "host_ids[]", host.id, selected?(host), :class => 'host_select_boxes', :onClick => 'insertHostVal(this)' if hosts_controller? ->
18: <=name_column(host) >
19: </td>
20: <td><=h host.try(:os) %></td>

Gustavo Soares wrote:

Ohad Levy wrote:

thats nice :) can you refactor it so it uses the normal host list? (instead of copy paste almost the same code?)

I have tried, but I am getting the following error:

ActionView::TemplateError (undefined method `hosts_controller?' for #<ActionView::Base:0x2b81609bcfc8>) on line #17 of app/views/hosts/_minilist.html.erb:
14: <% hosts.each do |host| ->
15: <tr class="<= cycle("even", "odd") ->">
16: <td>
17: <= check_box_tag "host_ids[]", host.id, selected?(host), :class => 'host_select_boxes', :onClick => 'insertHostVal(this)' if hosts_controller? ->
18: <=name_column(host) >
19: </td>
20: <td><=h host.try(:os) %></td>

sorry about that... the hosts_helper was missing :))

Gustavo Soares wrote:

done.

Ohad, if you think it is ok now, please you may close this issue.

Thanks in advance,
Gus

Hi Gus, Sorry for the late response.. moving a country.

can you please squash it? (so it would appear as one commit against the current develop branch).

thanks,
Ohad

Hi Gus,

please let me know if you can find the time to finish this patch - thanks

Hi Ohad,

I believe the patch is finished.. you asked me to squash it, to appear as one commit. But I didn't get the point.. since it seems not related to the implementation of the patch.

Gus

Gustavo Soares wrote:

Hi Ohad,

I believe the patch is finished.. you asked me to squash it, to appear as one commit. But I didn't get the point.. since it seems not related to the implementation of the patch.

Maybe I'm just confused, but there are many patches on your branch, which one is the right one (the one above undo some other changes that were introduced in an earlier commit..)

I would appreciate it if you could create a new single commit, which I could merge ontop of the latest develop branch.

take a look now and see if it's ok.

http://github.com/gustavosoares/foreman/commit/7c8e596fa424a8d5878601b832def76d8d269d46

(the undos that you saw was after some comments that you made earlier in this thread)

Gustavo Soares wrote:

take a look now and see if it's ok.

http://github.com/gustavosoares/foreman/commit/7c8e596fa424a8d5878601b832def76d8d269d46

(the undos that you saw was after some comments that you made earlier in this thread)

Hi Gus,
I'm not sure which commit I should be using... is it possible for you to start a new branch (based on the current development branch)
something in the line of:

git remote add upstream git://github.com/ohadlevy/foreman.git
git fetch upstream

git checkout -b feature/360 upstream/develop
apply your modifications (the original patch?)

(if you want to ensure that all test cases are running, type rake:test)

git commit -m "fixes 360 ......." 
git push

are you availble on irc? (#theforeman at freenode) - probably much easier to discuss it there.

Thanks,
Ohad

All right, let me know if you need anything.

Meanwhile I will still be using the previous implementation in the foreman version that I've beeng using.. :))

I will watch the railscasts video.

Ohad Levy wrote:

I've reviewed the patch, and I'm working on generalizing it (so we can reuse it in many different places).

I'm not so happy with the current implementation that we have(based on search logic) and might accept a simple solution like http://railscasts.com/episodes/228-sortable-table-columns.

in any case, this requires a bit of plumping before we can get it in properly...