Project

General

Profile

Actions

Bug #36038

closed

Add validations for Simplified ACS update via hammer

Added by Quinn James almost 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Repositories
Target version:
Fixed in Releases:
Found in Releases:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=2160112

Description of problem:
Using hammer we are restricted to provide some particular arguments for Simplified ACS when we create one. However, we are not restricted to provide the same arguments when we update an existing Simplified ACS.

In particular, the arguments and validations are:
Validation on
Argument Create Update
--base-url ok X
--subpaths ok X
--verify-ssl X X
--ssl-ca-cert-id ok X
--ssl-client-cert-id ok X
--ssl-client-cert-id ok X
--upstream-password ok X
--upstream-username ok X

The purpose of this BZ is to add the validation where missing (see the X in the table above)

Version-Release number of selected component (if applicable):
6.13.0 snap 5

How reproducible:
always

Steps to Reproduce:
1. Have a Satellite with Simplified ACS created
2. Update the ACS using restricted args:
  1. hammer alternate-content-source update --id 56 --base-url "https://content.example.com/" --subpaths "yums/,files/" --verify-ssl true --ssl-ca-cert-id 1 --ssl-client-cert-id 1 --ssl-client-cert-id 1 --upstream-username "john" --upstream-password "strong"

Actual results:
Alternate Content Source updated.

Expected results:
Could not update the Alternate Content Source.:
Validation failed: <argument> must be blank

Actions #1

Updated by The Foreman Bot almost 2 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/10435 added
Actions #2

Updated by The Foreman Bot almost 2 years ago

  • Pull request https://github.com/Katello/katello/pull/10436 added
Actions #3

Updated by Ian Ballou almost 2 years ago

  • Subject changed from Add validations for Simplified ACS update via hammer to Add validations for Simplified ACS update via hammer
  • Category set to Repositories
  • Assignee set to Quinn James
  • Target version set to Katello 4.8.0
  • Triaged changed from No to Yes
  • Pull request deleted (https://github.com/Katello/katello/pull/10436)
Actions #4

Updated by The Foreman Bot almost 2 years ago

  • Pull request https://github.com/Katello/katello/pull/10454 added
Actions #5

Updated by The Foreman Bot almost 2 years ago

  • Fixed in Releases Katello 4.8.0 added
Actions #6

Updated by Anonymous almost 2 years ago

  • Status changed from Ready For Testing to Closed
Actions

Also available in: Atom PDF