Project

General

Profile

Bug #36138

Invalid syntax for curl --time-cond

Added by Leos Stejskal about 1 month ago. Updated 10 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Leos Stejskal
Category:
Core
Target version:
-
Difficulty:
Triaged:
Yes
Bugzilla link:
Pull request:
https://github.com/theforeman/smart-proxy/pull/858, https://github.com/theforeman/smart-proxy/pull/859, https://github.com/theforeman/smart-proxy/pull/856
Fixed in Releases:
Foreman - 3.5.2, Foreman - 3.6.0
Found in Releases:
Red Hat JIRA:

Description

According to Curl man page, syntax for --time-cond attribute
should be "--time-cond file <path>", not "--time-cond <path>".

This can cause issues with outdated vmlinuz and initrd.im files,
once the files are downloaded, they are never replaced with never versions.

[0] https://curl.se/docs/manpage.html

Related issues

Related to Smart Proxy - Bug #36209: tftp initrd/vmlinux generation: curl malformedClosed

Associated revisions

Revision fba49ab1 (diff)
Added by Leos Stejskal 23 days ago

Fixes #36138 - Invalid syntax for curl --time-cond

According to Curl man page, syntax for --time-cond attribute
should be "--time-cond file <path>", not "--time-cond <path>".

This can cause issues with outdated vmlinuz and initrd.im files,
once the files are downloaded, they are never replaced with never versions.

[0] https://curl.se/docs/manpage.html

Fixes: 3d87c6f

History

#1 Updated by The Foreman Bot about 1 month ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/smart-proxy/pull/856 added

#2 Updated by The Foreman Bot 23 days ago

  • Fixed in Releases 3.7.0 added

#3 Updated by The Foreman Bot 23 days ago

  • Pull request https://github.com/theforeman/smart-proxy/pull/858 added

#4 Updated by The Foreman Bot 23 days ago

  • Pull request https://github.com/theforeman/smart-proxy/pull/859 added

#5 Updated by The Foreman Bot 23 days ago

  • Fixed in Releases 3.6.0 added

#6 Updated by Leos Stejskal 23 days ago

  • Status changed from Ready For Testing to Closed

#7 Updated by The Foreman Bot 23 days ago

  • Fixed in Releases 3.5.2 added

#8 Updated by Ewoud Kohl van Wijngaarden 22 days ago

  • Triaged changed from No to Yes
  • Category set to Core

#9 Updated by Ewoud Kohl van Wijngaarden 11 days ago

  • Fixed in Releases deleted (3.7.0)

#10 Updated by Oliver Freyermuth 10 days ago

Note that this has caused a regression, no new vmlinuz / initrd can be downloaded anymore after this change, see this report for more details:
https://projects.theforeman.org/issues/36209

In fact, the manpage linked here shows the example:

curl -z file https://example.com

i.e. the correct syntax is --time-cond <path>, as can be confirmed via:
$ touch foo && curl --time-cond file foo https://redhat.com
Warning: Illegal date format for -z, --time-cond (and not a file name). 
Warning: Disabling time condition. See curl_getdate(3) for valid date syntax.
curl: (6) Could not resolve host: foo
...

#11 Updated by Ewoud Kohl van Wijngaarden 10 days ago

  • Related to Bug #36209: tftp initrd/vmlinux generation: curl malformed added

Also available in: Atom PDF