Project

General

Profile

Actions
Copy link

Bug #36138

closed

Invalid syntax for curl --time-cond

Added by Leos Stejskal almost 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Leos Stejskal
Category:
Core
Target version:
-
Difficulty:
Triaged:
Yes
Bugzilla link:
Pull request:
https://github.com/theforeman/smart-proxy/pull/856, https://github.com/theforeman/smart-proxy/pull/858, https://github.com/theforeman/smart-proxy/pull/859
Fixed in Releases:
Foreman - 3.5.2, Foreman - 3.6.0
Found in Releases:
Red Hat JIRA:

Description

According to Curl man page, syntax for --time-cond attribute
should be "--time-cond file <path>", not "--time-cond <path>".

This can cause issues with outdated vmlinuz and initrd.im files,
once the files are downloaded, they are never replaced with never versions.

[0] https://curl.se/docs/manpage.html

Related issues 1 (0 open — 1 closed)

Related to Smart Proxy - Bug #36209: tftp initrd/vmlinux generation: curl malformedClosedEwoud Kohl van WijngaardenActions
Actions
Copy link
 #1

Updated by The Foreman Bot almost 2 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/smart-proxy/pull/856 added
Actions
Copy link
 #2

Updated by The Foreman Bot almost 2 years ago

  • Fixed in Releases 3.7.0 added
Actions
Copy link
 #3

Updated by The Foreman Bot almost 2 years ago

  • Pull request https://github.com/theforeman/smart-proxy/pull/858 added
Actions
Copy link
 #4

Updated by The Foreman Bot almost 2 years ago

  • Pull request https://github.com/theforeman/smart-proxy/pull/859 added
Actions
Copy link
 #5

Updated by The Foreman Bot almost 2 years ago

  • Fixed in Releases 3.6.0 added
Actions
Copy link
 #6

Updated by Leos Stejskal almost 2 years ago

  • Status changed from Ready For Testing to Closed
Actions
Copy link
 #7

Updated by The Foreman Bot almost 2 years ago

  • Fixed in Releases 3.5.2 added
Actions
Copy link
 #8

Updated by Ewoud Kohl van Wijngaarden almost 2 years ago

  • Category set to Core
  • Triaged changed from No to Yes
Actions
Copy link
 #9

Updated by Ewoud Kohl van Wijngaarden almost 2 years ago

  • Fixed in Releases deleted (3.7.0)
Actions
Copy link
 #10

Updated by Oliver Freyermuth almost 2 years ago

Note that this has caused a regression, no new vmlinuz / initrd can be downloaded anymore after this change, see this report for more details:
https://projects.theforeman.org/issues/36209

In fact, the manpage linked here shows the example:

curl -z file https://example.com

i.e. the correct syntax is --time-cond <path>, as can be confirmed via:
$ touch foo && curl --time-cond file foo https://redhat.com
Warning: Illegal date format for -z, --time-cond (and not a file name). 
Warning: Disabling time condition. See curl_getdate(3) for valid date syntax.
curl: (6) Could not resolve host: foo
...

Actions
Copy link
 #11

Updated by Ewoud Kohl van Wijngaarden almost 2 years ago

  • Related to Bug #36209: tftp initrd/vmlinux generation: curl malformed added
Actions
Copy link

Also available in: Atom PDF