Project

General

Profile

Actions

Bug #36157

closed

Pulp headers are overwritten incorrectly during manifest pull

Added by Ian Ballou over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Container
Target version:
Difficulty:
Triaged:
Yes
Fixed in Releases:
Found in Releases:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=2174975

Description of problem:

This issue: https://bugzilla.redhat.com/show_bug.cgi?id=2102078

was fixed in Pulp but not Satellite as a whole, because Katello is overwriting Pulp's headers. This header overwriting code is left over from the Pulp 2 days so we can likely take it out altogether and rely on the headers that we get from Pulp.

Related code is here: https://github.com/Katello/katello/blame/master/app/controllers/katello/api/registry/registry_proxies_controller.rb#L169

We should be able to take Pulp's headers and redirect them right to the client.

The particular issue seems to be caused by the mediaType being blank in the manifest body from Pulp, where Katello then assumes that the content-type should be either 'application/vnd.docker.distribution.manifest.v1+json' or 'application/vnd.docker.distribution.manifest.v1+prettyjws'. However, the type could be "application/vnd.oci.image.manifest.v1+json".

Also, we are parsing the result as JSON, which should also be removed. It is unnecessary if we're simply redirecting Pulp's request.

Version-Release number of selected component (if applicable):

All Pulp 3 Satellite

See https://bugzilla.redhat.com/show_bug.cgi?id=2102078 for more details.

Actions #1

Updated by The Foreman Bot over 1 year ago

  • Status changed from New to Ready For Testing
  • Assignee set to Ian Ballou
  • Pull request https://github.com/Katello/katello/pull/10472 added
Actions #2

Updated by The Foreman Bot over 1 year ago

  • Fixed in Releases Katello 4.9.0 added
Actions #3

Updated by Ian Ballou over 1 year ago

  • Subject changed from Pulp headers are overwritten incorrectly during manifest pull to Pulp headers are overwritten incorrectly during manifest pull
  • Category set to Container
  • Status changed from Ready For Testing to Closed
  • Assignee deleted (Ian Ballou)
  • Target version set to Katello 4.8.0

Closing since the PR is merged.

Actions #4

Updated by Jeremy Lenz over 1 year ago

  • Triaged changed from No to Yes
Actions #5

Updated by The Foreman Bot over 1 year ago

  • Assignee set to Lucy Fu
Actions

Also available in: Atom PDF