Project

General

Profile

Actions
Copy link

Bug #36221

closed

Simplified ACS update fails to remove products if product has any empty URL repos

Added by Samir Jha about 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Samir Jha
Category:
Alternate Content Sources
Target version:
Katello 4.10.0
Difficulty:
easy
Triaged:
Yes
Bugzilla link:
2214331
Pull request:
https://github.com/Katello/katello/pull/10625
Fixed in Releases:
Katello 4.10.0
Found in Releases:
Red Hat JIRA:

Description

Steps tp reproduce:
Create a product.
Create a yum repository with URL, sync and everything you'd do normally.
Create another yum repo without a URL.

Create a simplified ACS and add the product to it.
Try removing that product from the ACS. It fails.

undefined method `smart_proxy_id' for nil:NilClass (NoMethodError)
/usr/share/gems/gems/katello-4.7.0.23/app/lib/actions/pulp3/alternate_content_source/delete.rb:6:in `plan'

We probably need to test presence of smart_proxy_acs before planning Pulp3::Orchestration::AlternateContentSource::Delete here: https://github.com/Katello/katello/blob/449e319762f962c33dafd8b123f3f7f1d9feb1f5/app/lib/actions/katello/alternate_content_source/update.rb#L74

Files

Screenshot from 2023-06-07 10-34-52.png View Screenshot from 2023-06-07 10-34-52.png 135 KB Samir Jha, 06/07/2023 02:35 PM
Actions
Copy link
 #1

Updated by Partha Aji about 2 years ago

  • Target version set to Katello 4.9.0
  • Difficulty set to easy
  • Triaged changed from No to Yes
Actions
Copy link
 #2

Updated by Samir Jha almost 2 years ago

  • Target version changed from Katello 4.9.0 to Katello 4.10.0
  • Triaged changed from Yes to No
Actions
Copy link
 #3

Updated by Ian Ballou almost 2 years ago

Actions
Copy link
 #4

Updated by Samir Jha almost 2 years ago

Was able to reproduce on nightly. Valid bug. Change needed in the same line of code as bug description.

Actions
Copy link
 #5

Updated by Quinn James almost 2 years ago

  • Triaged changed from No to Yes
Actions
Copy link
 #6

Updated by Ian Ballou almost 2 years ago

  • Bugzilla link set to 2214331
Actions
Copy link
 #7

Updated by The Foreman Bot almost 2 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Samir Jha
  • Pull request https://github.com/Katello/katello/pull/10625 added
Actions
Copy link
 #8

Updated by The Foreman Bot almost 2 years ago

  • Fixed in Releases Katello 4.10.0 added
Actions
Copy link
 #9

Updated by Samir Jha almost 2 years ago

  • Status changed from Ready For Testing to Closed
Actions
Copy link

Also available in: Atom PDF