Project

General

Profile

Actions

Bug #36273

closed

Internal user with the role 'Ansible Roles Manager' could not able to edit/override the ansible variable

Added by Nofar Kirshon almost 3 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Difficulty:
Triaged:
No
Fixed in Releases:
Found in Releases:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=2181595

Description of problem:
ON the Satellite Web-UI. internal user with the role 'Ansible Roles Manager' could not able to edit/override the ansible variable
ansible variable is showing grayed out and cannot be overridden.
If you are an "Organization Administrator", the variable is not grayed out and the variable value can be overridden.

Version-Release number of selected component (if applicable):
satellite 6.12

How reproducible:
created a local satellite user, and provided the ansible role manager.
as a user when we tried to log in, we can not able to edit/override the ansible variable. we have the option for creating a variable and deleting it only.

Steps to Reproduce:
1. create an internal satellite user.
2. provide an Ansible Roles Manager role to the user
3. login and try to edit the ansible variable. it would be greyed out.

Actual results:
As a local user, the ansible variable is greyed out and could not able to modify

Expected results:
As a local user with Ansible Roles Manager, should have access to edit the ansible variable.

Additional info:


Subtasks 1 (0 open1 closed)

Foreman - Feature #36663: Add LookupValue permissionsClosedNofar KirshonActions

Related issues 2 (1 open1 closed)

Related to Foreman - Bug #36880: Include LookupValue permissions in fixturesClosedNofar KirshonActions
Related to Ansible - Bug #37338: Missing permission when editing Ansible variablesNewNofar KirshonActions
Actions #1

Updated by Pavel Moravec over 2 years ago

  • Subject changed from Internal user with the role 'Ansible Roles Manager' could not able to edit/override the ansible variable to Internal user with the role 'Ansible Roles Manager' could not able to edit/override the ansible variable

A codefix is one-liner:

https://github.com/theforeman/foreman_ansible/blob/master/app/controllers/api/v2/ansible_override_values_controller.rb#L27

needs s/:edit_external_variables/:edit_ansible_variables/1

Actions #2

Updated by Pavel Moravec over 2 years ago

  • Pull request https://github.com/theforeman/foreman_ansible/pull/633 added
Actions #3

Updated by Nofar Kirshon over 2 years ago

  • Assignee set to Nofar Kirshon
Actions #4

Updated by The Foreman Bot over 2 years ago

  • Status changed from New to Ready For Testing
Actions #5

Updated by Nofar Kirshon over 2 years ago

  • Related to Bug #36880: Include LookupValue permissions in fixtures added
Actions #6

Updated by The Foreman Bot over 2 years ago

  • Fixed in Releases foreman_ansible-12.0.6 added
Actions #7

Updated by Nofar Kirshon over 2 years ago

  • Status changed from Ready For Testing to Closed
Actions #8

Updated by Nofar Kirshon about 2 years ago

  • Fixed in Releases foreman_ansible-13.0.0 added
  • Fixed in Releases deleted (foreman_ansible-12.0.6)
Actions #9

Updated by Nofar Kirshon almost 2 years ago

  • Related to Bug #37338: Missing permission when editing Ansible variables added
Actions

Also available in: Atom PDF