Bug #36293
closed
Awk/grep should be more strict
Description
When I wanted to debug a template I forgot to type https://github.com/theforeman/foreman/blob/3.3-stable/app/views/unattended/provisioning_templates/registration/global_registration.erb#L15 (running each command step by step)
And I got a issue that third word isn't the UUID https://github.com/theforeman/foreman/blob/9962f72c635838ced1da86a7e818e2c431c3853e/app/views/unattended/provisioning_templates/registration/global_registration.erb#L118
If we want to match a UUID we should match a UUID not something hazardous like third word. It will be more resistent to change of output.
I don't have other example of stricter command might be needed but would happy to fix them.
Updated by The Foreman Bot over 1 year ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/9680 added
Updated by Ewoud Kohl van Wijngaarden over 1 year ago
- Fixed in Releases deleted (
3.7.0)
Please don't set Fixed in Releases because it's automatically set when something is merged.
Updated by Et7f3 please_edit_me over 1 year ago
Ok noted. The change was simple so I thought it will be merged quickly (and someone dire a first review)
Updated by Et7f3 please_edit_me over 1 year ago
- Status changed from Ready For Testing to Closed
Applied in changeset foreman|1950325b058e3a604e018b282dc077c3421963f4.
Updated by Ewoud Kohl van Wijngaarden over 1 year ago
- Category changed from Templates to Unattended installations
- Triaged changed from No to Yes