Project

General

Profile

Actions

Bug #36293

closed

Awk/grep should be more strict

Added by Et7f3 please_edit_me 8 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Category:
Unattended installations
Target version:
-
Difficulty:
easy
Triaged:
Yes
Fixed in Releases:
Found in Releases:

Description

When I wanted to debug a template I forgot to type https://github.com/theforeman/foreman/blob/3.3-stable/app/views/unattended/provisioning_templates/registration/global_registration.erb#L15 (running each command step by step)

And I got a issue that third word isn't the UUID https://github.com/theforeman/foreman/blob/9962f72c635838ced1da86a7e818e2c431c3853e/app/views/unattended/provisioning_templates/registration/global_registration.erb#L118

If we want to match a UUID we should match a UUID not something hazardous like third word. It will be more resistent to change of output.

I don't have other example of stricter command might be needed but would happy to fix them.

Actions #1

Updated by The Foreman Bot 8 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/9680 added
Actions #2

Updated by Ewoud Kohl van Wijngaarden 7 months ago

  • Fixed in Releases deleted (3.7.0)

Please don't set Fixed in Releases because it's automatically set when something is merged.

Actions #3

Updated by Et7f3 please_edit_me 7 months ago

Ok noted. The change was simple so I thought it will be merged quickly (and someone dire a first review)

Actions #4

Updated by The Foreman Bot 5 months ago

  • Fixed in Releases 3.8.0 added
Actions #5

Updated by Et7f3 please_edit_me 5 months ago

  • Status changed from Ready For Testing to Closed
Actions #6

Updated by Ewoud Kohl van Wijngaarden 3 months ago

  • Category changed from Templates to Unattended installations
  • Triaged changed from No to Yes
Actions

Also available in: Atom PDF