The current snippet renders vlan interfaces as "vlan=vlanXXX:ensY" which is against acceptable options. It should be "vlan=ensY.XXX:ensY". The host ends up with vlanXXX interfaces with no IPs and no links

I believe the snippet should be changed as follows:

from
options.push("vlan=vlan#{iface.tag}:#{iface.attached_to}")

to
options.push("vlan=#{iface.attached_to}.#{iface.tag}:#{iface.attached_to}")