Project

General

Profile

Actions
Copy link

Bug #36369

closed

Consider both 0 and 100 as valid exit codes for check-update yum action

Added by Sayan Das about 1 year ago. Updated 12 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Sayan Das
Category:
-
Target version:
-
Difficulty:
easy
Triaged:
No
Bugzilla link:
2073535
Pull request:
https://github.com/theforeman/foreman_maintain/pull/729, https://github.com/theforeman/foreman_maintain/pull/743
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

Right now in https://github.com/theforeman/foreman_maintain/blob/master/lib/foreman_maintain/package_manager/yum.rb#L70-L73 we only consider exit code 100 as the code_of_success.

But if no package updates are available, Then satellite-maintain fails the check-update step as the exit code, in this case, would be 0.

If no package updates are present and the exit code from yum is 0, then also the check-update action should pass as a successful execution.

Actions
Copy link
 #1

Updated by The Foreman Bot about 1 year ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman_maintain/pull/729 added
Actions
Copy link
 #2

Updated by Sayan Das about 1 year ago

  • Status changed from Ready For Testing to Closed
Actions
Copy link
 #3

Updated by The Foreman Bot 12 months ago

  • Pull request https://github.com/theforeman/foreman_maintain/pull/743 added
Actions
Copy link

Also available in: Atom PDF