Project

General

Profile

Actions

Bug #36393

closed

global registration should not create hosts as "managed" or "to be built"

Added by Evgeni Golov about 1 year ago. Updated 10 months ago.

Status:
Closed
Priority:
Normal
Category:
Host registration
Target version:
-

Description

When the "original" implementation of "create a host via curl" was done in 57d95c1685f28e0a52bd40fc26dd66d24adc0288, the create_host_curl method contained "build": "false", "managed": "false" in the payload, as this is IMHO the correct thing to do (the host is already created, so build:false is obvious, managed:false also makes sense as we do not submit enough data to create a fully managed host).

this also matches the behaviour of bootstrap.py:
https://github.com/Katello/katello-client-bootstrap/blob/master/bootstrap.py#L926
https://github.com/Katello/katello-client-bootstrap/blob/master/bootstrap.py#L936-L939

Now when things were split up into "plain Foreman" and "Foreman with Katello" in 2110556a713d53d5f09f8af35016ee92f0403572, the Katello part is missing the build:false and managed:false entries

This means that every host registration in Katello now needs to flip the machine back to "it's built" state, costing precious time during registration.

Actions #1

Updated by Ewoud Kohl van Wijngaarden about 1 year ago

This came up in https://community.theforeman.org/t/benchmarking-katello-using-host-registration/33495 and it's also mentioned that besides costing precious time it could even cause host rebuilds which can lead to data loss.

Actions #2

Updated by Evgeni Golov about 1 year ago

  • Bugzilla link set to 2212630
Actions #3

Updated by The Foreman Bot almost 1 year ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/9746 added
Actions #4

Updated by The Foreman Bot 11 months ago

  • Fixed in Releases 3.8.0 added
Actions #5

Updated by The Foreman Bot 11 months ago

  • Assignee set to Ewoud Kohl van Wijngaarden
  • Pull request https://github.com/theforeman/foreman/pull/9788 added
Actions #6

Updated by The Foreman Bot 11 months ago

  • Pull request https://github.com/theforeman/foreman/pull/9789 added
Actions #7

Updated by Leos Stejskal 11 months ago

  • Status changed from Ready For Testing to Closed
Actions #8

Updated by The Foreman Bot 11 months ago

  • Fixed in Releases 3.7.1 added
Actions #9

Updated by The Foreman Bot 11 months ago

  • Fixed in Releases 3.6.2 added
Actions #10

Updated by Ewoud Kohl van Wijngaarden 10 months ago

  • Triaged changed from No to Yes
Actions

Also available in: Atom PDF