Project

General

Profile

Actions
Copy link

Feature #36984

closed

Exclude all subdirectories for vendor in .rubocop.yaml

Added by dosas please_edit_me about 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
foreman_ansible-12.0.6
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman_ansible/pull/677
Fixed in Releases:
foreman_ansible-13.0.3
Found in Releases:
Red Hat JIRA:

Description

I stumbled upon this problem when executing rubocop for foreman_ansible locally and in gitlab ci
https://github.com/rubocop/rubocop/issues/9832

Change the line here
https://github.com/theforeman/foreman_ansible/blob/master/.rubocop.yml#L16

from
```
'vendor/bundle/**/*'
```
to

```
'vendor/**/*'
```

This would be the same as in the default config: https://github.com/rubocop/rubocop/blob/master/config/default.yml#L68

Actions
Copy link
 #1

Updated by dosas please_edit_me about 1 year ago

  • Tracker changed from Bug to Feature
  • Description updated (diff)
Actions
Copy link
 #2

Updated by The Foreman Bot about 1 year ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman_ansible/pull/677 added
Actions
Copy link
 #3

Updated by The Foreman Bot about 1 year ago

  • Fixed in Releases foreman_ansible-13.0.0 added
Actions
Copy link
 #4

Updated by dosas please_edit_me about 1 year ago

  • Status changed from Ready For Testing to Closed
Actions
Copy link
 #5

Updated by Nofar Alfassi about 1 year ago

  • Fixed in Releases foreman_ansible-13.0.3 added
  • Fixed in Releases deleted (foreman_ansible-13.0.0)
Actions
Copy link

Also available in: Atom PDF