Plugins » Katello

Hi dosas

Will you be submitting a PR?

(Make sure to take into account foreman-rubocop which katello uses for rubocop config on our CI; not sure how that will come into play here)

Jeremy Lenz wrote in #note-2:

Hi dosas

Will you be submitting a PR?

(Make sure to take into account foreman-rubocop which katello uses for rubocop config on our CI; not sure how that will come into play here)

I was in the process of creating a PR.

I added theforman-rubocop (0.0.6) as recommended here https://github.com/theforeman/theforeman-rubocop/blob/main/docs/github_action.md#plugin-gemfile

I choose the version 0.0.6 since this is also the version used in foreman https://github.com/theforeman/theforeman-rubocop/blob/main/docs/github_action.md#plugin-gemfile

When running rubocop this leads to hundreds of errors.

Is rubocop used at all in katello development or CI?

Hi Dosas,

Thanks for looking into this.

We currently run rubocop from the ../foreman directory in CI and development.

That said, there is a draft underway already to change the CI workflow, which includes adding rubocop to katello as a development dependency, which you can follow and suggest feedback here: https://github.com/Katello/katello/pull/10780

I'll leave this issue in 'need more information' status now, and we'll circle back to see if there is any other concern.

Kind regards,

Hi William,

thank you for the hint. This PR should solve the issue.