Bug #36998
closedMissing development dependencies for rubocop
Description
The requires from the .rubocop.yaml https://github.com/Katello/katello/blob/master/.rubocop.yml#L2
are not tracked as dependency in the gemfile or gempsec.
It should be possible to run rubocop with the dependencies given in the project:
Thus the following dependencies should be added to .gemspec:
```
gem.add_development_dependency "rubocop-performance"
gem.add_development_dependency "rubocop-rails"
gem.add_development_dependency "rubocop-minitest"
```
Updated by Jeremy Lenz 10 months ago
Hi dosas
Will you be submitting a PR?
(Make sure to take into account foreman-rubocop which katello uses for rubocop config on our CI; not sure how that will come into play here)
Updated by dosas please_edit_me 10 months ago
Jeremy Lenz wrote in #note-2:
Hi dosas
Will you be submitting a PR?
(Make sure to take into account foreman-rubocop which katello uses for rubocop config on our CI; not sure how that will come into play here)
I was in the process of creating a PR.
I added theforman-rubocop (0.0.6) as recommended here https://github.com/theforeman/theforeman-rubocop/blob/main/docs/github_action.md#plugin-gemfile
I choose the version 0.0.6 since this is also the version used in foreman https://github.com/theforeman/theforeman-rubocop/blob/main/docs/github_action.md#plugin-gemfile
When running rubocop this leads to hundreds of errors.
Is rubocop used at all in katello development or CI?
Updated by William Clark 9 months ago
- Status changed from New to Need more information
Updated by William Clark 9 months ago
Hi Dosas,
Thanks for looking into this.
We currently run rubocop from the ../foreman directory in CI and development.
That said, there is a draft underway already to change the CI workflow, which includes adding rubocop to katello as a development dependency, which you can follow and suggest feedback here: https://github.com/Katello/katello/pull/10780
I'll leave this issue in 'need more information' status now, and we'll circle back to see if there is any other concern.
Kind regards,
Updated by dosas please_edit_me 9 months ago
Hi William,
thank you for the hint. This PR should solve the issue.
Updated by Ian Ballou 9 months ago
- Status changed from Need more information to New
- Target version set to Katello 4.13.0
- Triaged changed from No to Yes
Triaging -- To be resolved by https://github.com/Katello/katello/pull/10780
Updated by The Foreman Bot 9 months ago
- Status changed from New to Ready For Testing
- Assignee set to Evgeni Golov
- Pull request https://github.com/Katello/katello/pull/10857 added
Updated by Evgeni Golov 9 months ago
- Status changed from Ready For Testing to Closed
Applied in changeset katello|2e084c9018b574453084827c9ff548d6379c4110.
Updated by The Foreman Bot 6 months ago
- Pull request https://github.com/Katello/katello/pull/10974 added