Bug #36998
closed
Missing development dependencies for rubocop
Added by dosas please_edit_me 10 months ago.
Updated 6 months ago.
Description
The requires from the .rubocop.yaml https://github.com/Katello/katello/blob/master/.rubocop.yml#L2
are not tracked as dependency in the gemfile or gempsec.
It should be possible to run rubocop with the dependencies given in the project:
Thus the following dependencies should be added to .gemspec:
```
gem.add_development_dependency "rubocop-performance"
gem.add_development_dependency "rubocop-rails"
gem.add_development_dependency "rubocop-minitest"
```
Hi dosas
Will you be submitting a PR?
(Make sure to take into account foreman-rubocop which katello uses for rubocop config on our CI; not sure how that will come into play here)
- Status changed from New to Need more information
Hi Dosas,
Thanks for looking into this.
We currently run rubocop from the ../foreman directory in CI and development.
That said, there is a draft underway already to change the CI workflow, which includes adding rubocop to katello as a development dependency, which you can follow and suggest feedback here: https://github.com/Katello/katello/pull/10780
I'll leave this issue in 'need more information' status now, and we'll circle back to see if there is any other concern.
Kind regards,
Hi William,
thank you for the hint. This PR should solve the issue.
- Status changed from Need more information to New
- Target version set to Katello 4.13.0
- Triaged changed from No to Yes
- Status changed from New to Ready For Testing
- Assignee set to Evgeni Golov
- Pull request https://github.com/Katello/katello/pull/10857 added
- Fixed in Releases Katello 4.12.0 added
- Status changed from Ready For Testing to Closed
- Pull request https://github.com/Katello/katello/pull/10974 added
- Fixed in Releases Katello 4.11.2 added
Also available in: Atom
PDF