Project

General

Profile

Actions

Bug #37156

closed

Pin victory-core to pre-36.9.0

Added by Samir Jha 8 months ago. Updated 8 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Web Interface
Target version:
-
Difficulty:
trivial
Triaged:
No
Fixed in Releases:
Found in Releases:

Description

import { ChartPie } from '@patternfly/react-charts';
fails with

TypeError: Cannot read property 'primitiveProps' of undefined
at Object.<anonymous> (../foreman/node_modules/@patternfly/react-charts/src/components/ChartCursorTooltip/ChartCursorFlyout.tsx:111:18)
      at Object.<anonymous> (../foreman/node_modules/@patternfly/react-charts/src/components/ChartCursorTooltip/index.ts:1:1)

This is probably the package victory-core had a new release 36.9.0 which includes this change:
FormidableLabs/victory#2758
which seems to break the use of CommonProps.

Refer to PF issue: https://github.com/patternfly/patternfly-react/issues/10064


Related issues 1 (0 open1 closed)

Related to Foreman - Bug #37255: _victoryCore.Helpers.isFunction is not a functionClosedEvgeni GolovActions
Actions #1

Updated by Samir Jha 8 months ago

  • Subject changed from Pin victory-core to to Pin victory-core to pre-36.9.0
Actions #2

Updated by The Foreman Bot 8 months ago

  • Status changed from New to Ready For Testing
  • Assignee set to Samir Jha
  • Pull request https://github.com/theforeman/foreman/pull/10043 added
Actions #3

Updated by The Foreman Bot 8 months ago

  • Fixed in Releases 3.10.0 added
Actions #4

Updated by Anonymous 8 months ago

  • Status changed from Ready For Testing to Closed
Actions #5

Updated by Evgeni Golov 7 months ago

  • Related to Bug #37255: _victoryCore.Helpers.isFunction is not a function added
Actions

Also available in: Atom PDF