Project

General

Profile

Actions
Copy link

Refactor #37194

closed

Update Hard Coded rhsm url to use an env setting

Added by Partha Aji 9 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Partha Aji
Category:
Subscriptions
Target version:
Katello 4.14.0
Branch:
Difficulty:
Triaged:
Yes
Bugzilla link:
Pull request:
https://github.com/Katello/katello/pull/10902
Fixed in Releases:
Katello 4.14.0
Found in Releases:
Red Hat JIRA:

Description

https://github.com/Katello/katello/blob/master/app/lib/katello/resources/candlepin/upstream_job.rb#L7 hard codes the rhsm url. This makes it impossible to run this operation in a stage environment without changing the url in this file.
Better alternative will be something along having an env variable like RHSM_REDHAT_API_URL. The user then set its value the service file similar to

# cat /etc/systemd/system/foreman.service.d/override.conf
[Service]
Environment=RHSM_REDHAT_API_URL=https://<stage rhsm>/subscription

and the default being the present default.
RH Cloud has a similar strategy to help with the qe env

https://github.com/theforeman/foreman_rh_cloud/blob/foreman_3_9/lib/foreman_inventory_upload.rb#L54-L57

Actions
Copy link
 #1

Updated by Samir Jha 9 months ago

  • Tracker changed from Support to Refactor
  • Target version set to Katello 4.13.0
  • Triaged changed from No to Yes
Actions
Copy link
 #2

Updated by The Foreman Bot 9 months ago

  • Status changed from New to Ready For Testing
  • Assignee set to Partha Aji
  • Pull request https://github.com/Katello/katello/pull/10902 added
Actions
Copy link
 #3

Updated by Partha Aji 5 months ago

  • Target version changed from Katello 4.13.0 to Katello 4.14.0
Actions
Copy link
 #4

Updated by The Foreman Bot 4 months ago

  • Fixed in Releases Katello 4.14.0 added
Actions
Copy link
 #5

Updated by Partha Aji 4 months ago

  • Status changed from Ready For Testing to Closed
Actions
Copy link

Also available in: Atom PDF