Project

General

Profile

Actions

Bug #37240

closed

Duplicate repositories in content view versions warning is always active

Added by Quirin Pamp 10 months ago. Updated 9 months ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Web UI
Target version:
Difficulty:
trivial
Triaged:
Yes
Fixed in Releases:
Found in Releases:

Description

UI Bug: When publishing a new CCV version, I always see the following warning/info message:

Duplicate repositories in content view versions
Repositories common to the selected content view versions will merge, resulting in a composite content view that is a union of all content from each of the content view versions.

This is displayed whether or not there are any duplicate constituent CV repositories.

I am pretty sure the bug is this line: https://github.com/Katello/katello/blob/master/webpack/scenes/ContentViews/Publish/CVPublishForm.js#L69

I am pretty sure it needs to be && instead of ||. Right now `duplicateRepos` is normally an empty list, so `duplicateRepos !== null` is true making the entire disjunction true in the case when the message should not be displayed.

Since I don't have the dev environment/experience for fixing js bugs, I am hoping someone else can quickly verify the fix and open a PR.


Related issues 1 (0 open1 closed)

Follows Katello - Bug #36492: Bring back duplicate content warning for composite CVs for non-docker reposClosedSamir JhaActions
Actions #1

Updated by The Foreman Bot 10 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/10928 added
Actions #2

Updated by Markus Bucher 10 months ago

  • Follows Bug #36492: Bring back duplicate content warning for composite CVs for non-docker repos added
Actions #3

Updated by Jeremy Lenz 9 months ago

  • Target version set to Katello 4.11.2
  • Triaged changed from No to Yes
Actions #4

Updated by Samir Jha 9 months ago

  • Bugzilla link set to 2269403
Actions #5

Updated by The Foreman Bot 9 months ago

  • Fixed in Releases Katello 4.13.0 added
Actions #6

Updated by Markus Bucher 9 months ago

  • Status changed from Ready For Testing to Closed
Actions #7

Updated by The Foreman Bot 9 months ago

  • Fixed in Releases Katello 4.12.0 added
Actions

Also available in: Atom PDF