Bug #37240
closedDuplicate repositories in content view versions warning is always active
Description
UI Bug: When publishing a new CCV version, I always see the following warning/info message:
Duplicate repositories in content view versions
Repositories common to the selected content view versions will merge, resulting in a composite content view that is a union of all content from each of the content view versions.
This is displayed whether or not there are any duplicate constituent CV repositories.
I am pretty sure the bug is this line: https://github.com/Katello/katello/blob/master/webpack/scenes/ContentViews/Publish/CVPublishForm.js#L69
I am pretty sure it needs to be && instead of ||. Right now `duplicateRepos` is normally an empty list, so `duplicateRepos !== null` is true making the entire disjunction true in the case when the message should not be displayed.
Since I don't have the dev environment/experience for fixing js bugs, I am hoping someone else can quickly verify the fix and open a PR.
Updated by The Foreman Bot 8 months ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/Katello/katello/pull/10928 added
Updated by Markus Bucher 8 months ago
- Follows Bug #36492: Bring back duplicate content warning for composite CVs for non-docker repos added
Updated by Jeremy Lenz 8 months ago
- Target version set to Katello 4.11.2
- Triaged changed from No to Yes
Updated by Markus Bucher 8 months ago
- Status changed from Ready For Testing to Closed
Applied in changeset katello|02fc31338733997140be89cfc63b473749cd8c2b.