Project

General

Profile

Actions
Copy link

Refactor #37247

closed

results.map should appear directly in HostsIndex index.js

Added by Jeremy Lenz 11 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Jeremy Lenz
Category:
Inventory
Target version:
3.11.0
Difficulty:
Triaged:
Yes
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/10093, https://github.com/theforeman/foreman/pull/10110
Fixed in Releases:
3.11.0
Found in Releases:
Red Hat JIRA:

Description

Currently <HostsIndex> renders a <TableIndexPage> which renders a {children || <Table>} which is actually what has the results.map and renders a <TableComposable>.

The effect of this is that you have to go on a wild goose chase through at least 4 files to see what your table rows will render. This needs refactoring, preferably so that the results.map can appear directly in <HostsIndex>.

Actions
Copy link
 #1

Updated by The Foreman Bot 11 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/10093 added
Actions
Copy link
 #2

Updated by The Foreman Bot 11 months ago

  • Pull request https://github.com/theforeman/foreman/pull/10110 added
Actions
Copy link
 #3

Updated by Jeremy Lenz 11 months ago

  • Pull request deleted (https://github.com/theforeman/foreman/pull/10110)
Actions
Copy link
 #4

Updated by The Foreman Bot 10 months ago

  • Fixed in Releases 3.11.0 added
Actions
Copy link
 #5

Updated by The Foreman Bot 10 months ago

  • Pull request https://github.com/theforeman/foreman/pull/10110 added
Actions
Copy link
 #6

Updated by Jeremy Lenz 10 months ago

  • Status changed from Ready For Testing to Closed
Actions
Copy link
 #7

Updated by Ewoud Kohl van Wijngaarden 7 months ago

  • Triaged changed from No to Yes
  • Category changed from Web Interface to Inventory
Actions
Copy link

Also available in: Atom PDF